Resolve SSW-312 (has_expected_pool_value traverses output value just once)
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking:
- original version
34 => { cpu: 5238830255, mem: 13459313 },
35 => { cpu: 5367257843, mem: 13789894 }
- optimized version
34 => { cpu: 5222871729, mem: 13414480 },
35 => { cpu: 5356877915, mem: 13757945 }
Savings:
- for 34 orders: 15.958.526 cpu and 44.833 mem
- for 35 orders: 10.379.928 cpu and 31.949 mem
…s part of the pair
francolq
changed the title
has_expected_pool_value traverses output value just oncehas_expected_pool_value traverses output value just once)
|
I renamed this PR to show that it resolves SSW-312 |
…ected_pool_value-optimization
francolq
approved these changes
Mar 5, 2024
Quantumplation
deleted the
ignaciodopazo/has_expected_pool_value-optimization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking:
original version 34 => { cpu: 5238830255, mem: 13459313 },
35 => { cpu: 5367257843, mem: 13789894 }
optimized version 34 => { cpu: 5222871729, mem: 13414480 },
35 => { cpu: 5356877915, mem: 13757945 }
Savings: