Resolve SSW-101 #54
Merged
Resolve SSW-101 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settings UTXO required the output to have the exact same value as the input But, this means we can't change the size in bytes of the datum, and the output might be locked if the minUTXO ever increases. To resolve this, we compare `without_lovelace` of the own_output.value and own_input.value. This allows the ADA to vary arbitrarily, so the minUTXO can be adjusted. Two things to note about the safety of this: - We never expect an appreciable amount of ADA at this UTXO, essentially just the minUTXO, so the fact that someone can take any surplus if the minUTXO changes is not an issue - Only the settings admin and the treasury admin can spend the UTXO anyway
|
Looks good, it solves SSW-101. |
francolq
approved these changes
Feb 21, 2024
francolq
approved these changes
Mar 5, 2024
|
Merge conflicts should be resolved, added tests, @Quantumplation or @rrruko since I can't merge due to being last commit author |
|
LGTM! |
rrruko
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings UTXO required the output to have the exact same value as
the input
But, this means we can't change the size in bytes of the datum, and the
output might be locked if the minUTXO ever increases.
To resolve this, we compare
without_lovelaceof the own_output.valueand own_input.value. This allows the ADA to vary arbitrarily, so the
minUTXO can be adjusted.
Two things to note about the safety of this:
just the minUTXO, so the fact that someone can take any surplus if the
minUTXO changes is not an issue
anyway