Resolve SSW-204 #57
Merged
Resolve SSW-204 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither the settings admin or the treasury admin could update the authorized staking keys, so the list would be locked from the start. This updates it to allow the treasury admin to update the authorized staking keys. This also addresses a readability concern that lead to this bug: we were just checking that a bunch of fields were unmodified, which makes it difficult to tell at a glance which fields are allowed to change. So, instead, we now construct an "allowed" datum, using either the inputs or outputs as a base, and then overriding the fields that can change (or should remain the same).
francolq
approved these changes
Feb 28, 2024
rrruko
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither the settings admin or the treasury admin could update the
authorized staking keys, so the list would be locked from the start.
This updates it to allow the treasury admin to update the authorized
staking keys.
This also addresses a readability concern that lead to this bug: we were
just checking that a bunch of fields were unmodified, which makes it
difficult to tell at a glance which fields are allowed to change.
So, instead, we now construct an "allowed" datum, using either the
inputs or outputs as a base, and then overriding the fields that can
change (or should remain the same).