Resolve SSW-306 #58
Merged
Resolve SSW-306 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already know the number of LP tokens being minted, we can check
that it is correct with an is_sqrt function, rather than calculating the
sqrt directly.
We're not overly concerned with the pool creation, but it was simple
enough to implement.
Base:
│ PASS [mem: 1173694, cpu: 470849067] mint_test
Fixed:
│ PASS [mem: 1056495, cpu: 395561132] mint_test
|
Nice! Solves SSW-306. If in the future is_sqrt is included in Aiken's stdlib, it can be imported and used. |
francolq
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already know the number of LP tokens being minted, we can check
that it is correct with an is_sqrt function, rather than calculating the
sqrt directly.
We're not overly concerned with the pool creation, but it was simple
enough to implement.
Base:
│ PASS [mem: 1173694, cpu: 470849067] mint_test
Fixed:
│ PASS [mem: 1056495, cpu: 395561132] mint_test