Resolve SSW-307 #59
Merged
Resolve SSW-307 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the MintLP redeemer path more efficient, which will minimize the impact on scoop costs. I also took some effort to convince myself in the comments above this branch that this (and other permutations) were safe, as this is the most likely (and most damaging) hack of a DEX, is finding some way to mint extra LP tokens.
|
LGTM, @ignaciodopazo will take a look also |
ignaciodopazo
approved these changes
Feb 21, 2024
francolq
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the MintLP redeemer path more efficient, which will minimize
the impact on scoop costs.
I also took some effort to convince myself in the comments above this
branch that this (and other permutations) were safe, as this is the most
likely (and most damaging) hack of a DEX, is finding some way to mint
extra LP tokens.