Refactors pool fees slightly #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pools might want different bid and ask fees, and they might want them at different cadence
The fee admin is a sundae multisig (so, an admin, a multisig, or a script) that can edit the fees, perhaps in response to a DAO vote, or some on-chain volatility policy, etc.
rrruko
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits
fees_per_10kintobid_fees_per_10kandask_fees_per_10kto specify the bid and ask fees separately.Also adds a
fee_managerthat is allowed to update the fees and update the fee manager. The idea is some pools may want to have someone manage the fees and react to volatility.I still need to add a
max_fee_pctproperty to the swap datum, so the user doesn't pay more than they expected if the manager changes the fee.I also wanted to refactor the fees to follow the format:
[(PosixTime, feePct)]But figured that was too much change before we launch, so I avoided doing that for now; we'll likely simplify with a new pool type in the future.