Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GLMakie precompiles on Julia 1.11.2 #329

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Support GLMakie precompiles on Julia 1.11.2 #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e72cbda
Support GLMakie precompile on Julia 1.11.2
kbarros Dec 4, 2024
b1b2512
Avoid crash on 1.11.1
kbarros Dec 4, 2024
5f068c3
Tweak
kbarros Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ WriteVTK = "64499a7a-5c06-52f2-abe2-ccb03c286192"

[extensions]
ExportVTKExt = "WriteVTK"
GLMakiePrecompilesExt = "GLMakie"
GLMakiePrecompilesExt = ["Makie", "GLMakie"]
PlottingExt = "Makie"
WGLMakiePrecompilesExt = "WGLMakie"
WGLMakiePrecompilesExt = ["Makie", "WGLMakie"]

[compat]
Brillouin = "0.5.19"
Expand Down
10 changes: 5 additions & 5 deletions ext/GLMakiePrecompilesExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
module GLMakiePrecompilesExt

import Sunny, GLMakie
import Sunny, Makie, GLMakie
import PrecompileTools as PT

# Julia 1.11.1 caused a change in the ordering of precompilation for extensions.
# See https://github.com/JuliaLang/julia/issues/56204#issuecomment-2439588043
@static if VERSION < v"1.11.1"
# Julia 1.11.1 broke extension precompiles, but this was fixed in 1.11.2.
# https://github.com/JuliaLang/julia/issues/56204#issuecomment-2439588043
@static if VERSION != v"1.11.1"

PT.@setup_workload begin
PT.@compile_workload begin
Expand All @@ -21,6 +21,6 @@ PT.@setup_workload begin
end
end

end # VERSION < v"1.11.1"
end

end
Loading