-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yeast 8.4.0 #229
Merged
Merged
yeast 8.4.0 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test if all model components are loaded when cobrapy is used
for compliance with cobrapy
feat: gene name compliance with cobrapy
…ctions" This reverts commit 3b83df2.
should be L-xylulose, not D-xylulose Co-Authored-By: Sebastián Mendoza Farías <[email protected]>
based on discussion from #187. Also features a function that prints duplicated stoichiometry Co-Authored-By: Sebastián Mendoza Farías <[email protected]>
same dicts as in commit 3b83df2 Co-Authored-By: Sebastián Mendoza Farías <[email protected]>
…X and KEGG) New reaction IDs are found during manual curation of reactions in the model. These IDs either replace the current model IDs or are added into the model (if no IDs were originally present). Inappropriately annotated or deprecated IDs have also been removed. Details of the changes, such as the rationale for the addition of IDs or changes of IDs are recorded in modifyID.tsv, under the various notes.
…aNetX, KEGG and ChEBI) New metabolite IDs are found during manual curation of metabolites in the model. These IDs either replace the current model IDs or are added into the model (if no IDs were originally present). Details of the changes, such as the rationale for the addition of IDs or changes of IDs are recorded in modifyID.tsv, under the various notes.
With the function mapIDsViaMNXref from RAVEN, model.rxnMetaNetXID is mapped as follows: 1) rxnMetaNetXID -> rxnKEGGID 2) rxnMetaNetXID -> rxnMetaCycID -> rxnKEGGID 3) rxnMetaNetXID -> rxnSEEDID -> rxnKEGGID Total unique rxnKEGGID added: 134
With the function mapIDsViaMNXref from RAVEN, model.metMetaNetXID is mapped as follows: 1) metMetaNetXID -> metKEGGID 2) metMetaNetXID -> metMetaCycID -> metKEGGID 3) metMetaNetXID -> metSEEDID -> metKEGGID Total unique metKEGGID added: 15
model.metChEBIID and model.metKEGGID is mapped to find new MNXMID(s). New MNXMID(s) will only be added if 1 of the following 3 criteria is met: a) Both metKEGGID and metChEBIID is mapped to the same MNXMID b) Only metKEGGID mapped to MNXMID, metFormula of new MNXMID matches model.metFormula c) Only metChEBIID mapped to MNXMID, metFormula of new MNXMID matches model.metFormula Total unique MNXMIDs added: 52
…yID.tsv Added lines 135 – 137, 168 – 170, 203 – 205 to remove metabolite ID annotation in model, based on modifyID.tsv. Minor correction made to modifyID.tsv: 1) Remove unnecessary metabolite and alternative metabolite ID entries which causes duplicated or lengthy notes 2) Correct errors generated when importing deprecated IDs into modifyID.tsv.
Co-authored-by: Eduard Kerkhoven <[email protected]>
Co-authored-by: Eduard Kerkhoven <[email protected]>
Co-authored-by: Eduard Kerkhoven <[email protected]>
New mapKEGGID.m is able to check whether MetaCyc or modelSEED data is downloaded/imported successfully, and clear warning message will be displayed if download/import is unsuccessful.
- in repo, EOL should be kept as LF, to prevent issues with development on both Unix and Windows machines - applied this new setting to all files in repo - also few small tweaks on which files not to include when downloading repo as ZIP Co-authored-by: eiden309 <[email protected]>
feat: specify EOL behaviour in gitattributes
Added functions for loading/saving the model in python in a more straightforward way. Also the id replacement is no longer necessary, as it was fixed in cobrapy. Updated the model as a test (will be reverted later)
minor changes, including shuffling of groups (as the latest cobrapy version still treats them as sets)
add a BiGG compliance flag that defaults to false when loading the model. If true, will read the annotation and use BiGG ids (if any)
model cannot be stored at this stage, as there are repeated ids in the BiGG dicts
introduce a copy suffix when id is repeated
taken from devel
feat: python I/O functions + BiGG compliance flag
Fix/unbalanced_rxns
BenjaSanchez
added
the
new release
PR from devel to master that leads to a new release
label
Jun 12, 2020
feiranl
approved these changes
Jun 12, 2020
hongzhonglu
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
as RAVEN made a new release
hongzhonglu
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapKEGGID.m
andmapMNXMID.m
for adding ids in model. Used them to add missing KEGG and MetaNetX ids for both metabolites and reactions (PR Fix/update_IDs #220).read_yeast_model
andwrite_yeast_model
for easier usage in python (PR feat: python I/O functions + BiGG compliance flag #224).checkSmatrixMNX.m
, bringing the number down to 17 reactions (PR Fix/unbalanced_rxns #222).LF
as EOL character (PR feat: specify EOL behaviour in gitattributes #221).NOTE: This release was made with the development version of COBRA toolbox, as the latest release is not able to keep BiGG ids.