Presentation of list of attributes in the Guidelines #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list. (More to do, but we got a lot done.)
* Use ATTCLASSES key instead of CLASSES, as we are not playing with model classes * Use generic output elements instead of output-specific output elements
…h — we think this is structurally ready, still needs CSS
Reverted Test/expected-results/test15.odd.html since there were many conflicts, and will address those next.
But note that this also will require a change in the GL's CSS in the TEI repo, I think
This was referenced Oct 18, 2023
|
I've now updated the CSS (in ba2d56c) and all tests are passing, so I am going to mark this as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket #592. Council decided to go with the vertical compressed visualization and this should be implemented in CSS
To do list: