Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sorting of tei:biblStruct when multiple dates available (#712) #715

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

HelenaSabel
Copy link
Member

@HelenaSabel HelenaSabel commented Nov 26, 2024

Test and Test2 pass, but actual fix is untested (however, due to the simplicity of the change, it might be unnecessary)

@HelenaSabel HelenaSabel added the status: fixUntested Someone has checked in a fix that has been insufficiently tested. label Nov 26, 2024
Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the HTML Guidelines built with this branch vs dev, and found no significant changes (not even to BIB, which surprised me).

The other two <xsl:sort> commands in html/html_core.xsl and the other one <xsl:sort> command in latex/latex_core.xsl¹ use the (path/to/nodes)[1] method rather than the head(path/to/nodes) method. I would mildly prefer that they all 5 use one or the other. I don’t really much care which, to be honest. (I had to look up what head() does, but as far as I can tell, they do the exact same thing.)

note
¹ Which begs the question — why is sorting different in HTML vs LaTeX?

Copy link
Contributor

@sabineseifert sabineseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and I remember we talked about that in a stylesheets meeting. But I still feel insecure concerning such stylesheets issues and should better not be relied upon.. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: fixUntested Someone has checked in a fix that has been insufficiently tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants