Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first teeny step in addressing #705 — make Makefile more readable #716

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

sydb
Copy link
Member

@sydb sydb commented Nov 26, 2024

This PR is intended to change how the "doc:" target in the Makefile looks, not what it does. This is just to make it easier to read & understand.

To test, besides the usual make test and make test2P, run the make doc cmd in the Stylesheets released or dev branch, and compare that output (release/xslcommon/doc/tei-xsl/) to the output of make doc in this branch. The only differences I found were:

  • version numbers
  • creation dates
  • ChangeLog

i.e., no significant change.

it does. This is just to make it easier to read & understand
@sydb sydb requested a review from ebeshero November 26, 2024 19:11
@sydb sydb added the target: build Concerning the build process, e.g. the Makefile or build.xml label Nov 26, 2024
@sydb sydb added this to the Release 7.58.0 milestone Nov 26, 2024
Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all much more lucid and should help us with next steps in modifying the "Stylebear".

@ebeshero
Copy link
Member

I went looking for changes in the output (not really expecting any)--and really, this performs exactly the same in my local dev branch as here. Which means we haven't munged anything. :-) I recommend merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: build Concerning the build process, e.g. the Makefile or build.xml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants