Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gno-dao): remove workaround #1318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(gno-dao): remove workaround #1318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7224220
fix(gno-dao): remove workaround
n0izn0iz Oct 30, 2024
5557097
Merge branch 'main' into daoregissuefixed
n0izn0iz Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions gno/r/dao_realm/dao_realm.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,22 +70,7 @@ func init() {

daoCore = dao_core.NewDAOCore(votingModuleFactory, proposalModulesFactories, messageHandlersFactories)

// dao_registry.Register(func() dao_interfaces.IDAOCore { return daoCore }, "DAO Realm", "Default testing DAO", "https://images.unsplash.com/photo-1477959858617-67f85cf4f1df?w=1080&fit=max")
}

// FIXME: the registry is currently broken in 'gno test', see https://github.com/gnolang/gno/issues/1852
// so we're exposing a way to register after DAO instantiation
func RegisterSelf() {
if registered {
panic("already registered")
}

dao_registry.Register(func() dao_interfaces.IDAOCore { return daoCore }, "DAO Realm", "Default testing DAO", "https://images.unsplash.com/photo-1477959858617-67f85cf4f1df?w=1080&fit=max")
registered = true
}

func Render(path string) string {
return daoCore.Render(path)
}

func VoteJSON(moduleIndex int, proposalID int, voteJSON string) {
Expand Down
Loading