feat(tdp_vars_defaults): changes in order tu use phoenix via knox #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierrotws
requested changes
Nov 19, 2024
|
Test to do : impersonate as another user from tdp_user and do a request to phoenix queryserver and check it fails. If not this a securty issue since tdp_user is not suppose to impersonate. |
I have tried to connect to the phoenix query server by impersonnating hbase from tdp_user and it failed. |
…nix.queryserver.remoteUserExtractor.param
|
@Pierrotws It is ok for you ? Merge is blocked until you approve this PR. |
Pierrotws
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please could you merge this PR, it fixes the #893 issue.
Regards