Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improved layout of RecipeCard, RecipeView, and how steps work #3417

Draft
wants to merge 3 commits into
base: feature/vue3
Choose a base branch
from

Conversation

skybird23333
Copy link

@skybird23333 skybird23333 commented Nov 29, 2024

Before

I dont have a before picture.

After

image
image
image

Changes

Recipe card

  • Now displays servings and time it takes to be ready.
  • The name is now embedded in the recipe image over a background.
  • New prop: info_badges with type infoBadgeProperties (currently 'serves' | 'time')
    • This allows controlling what badges are displayed on the card and in what order by passing in an array of strings which are the properties. This can be edited from inside the component, namely editing the InfoBadgeProperties type and the generateInfoBadges function.

Recipe view

  • The image is now slightly taller so you can see the food better.
  • The recipe name now embeds into the image like in recipe card, along with the author name, which is moved from the top left corner.
  • The layout of the page on PC now has two sides: The ingredients overview and steps will be on the left(main) side, while the remaining information and such are displayed on the right side.
  • Implemented <Recipe>.sourceUrl.
  • Implemented properties.
  • Removed the context menu next to the recipe name, which is now placed in the side bar, under the manage section.
  • Improved flow of browsing/checking ingredients.
    • Recipe overview is now named to Ingredients Overview, and is expanded by default.
    • Each step no longer display a full ingredients table, rather an inline list where items can be checked off by clicking on it.

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants