Merge pull request #494 from TarsCloud/fix/close/conn

fix: Setting the read timeout configuration is unreasonable, causing the service to exit and the connection not closed
TarsCloud · Jun 28, 2023 · ef30e68 · ef30e68
2 parents 2f562ac + 95554d7
commit ef30e68
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/tars/transport/tcphandler.go b/tars/transport/tcphandler.go
@@ -194,7 +194,9 @@ func (t *tcpHandler) CloseIdles(n int64) bool {
 		TLOG.Debugf("num invoke %d %v", atomic.LoadInt32(&conn.numInvoke), conn.idleTime+n > time.Now().Unix())
 		if atomic.LoadInt32(&conn.numInvoke) > 0 || conn.idleTime+n > time.Now().Unix() {
 			allClosed = false
+			return true
 		}
+		conn.conn.Close()
 		return true
 	})
 	return allClosed
@@ -235,8 +237,8 @@ func (t *tcpHandler) recv(connSt *connInfo) {
 		}
 		connSt.idleTime = time.Now().Unix()
 		n, err = conn.Read(buffer)
-		// TLOG.Debugf("%s closed: %d, read %d, nil buff: %d, err: %v", t.server.config.Address, atomic.LoadInt32(&t.server.isClosed), n, len(currBuffer), err)
 		if err != nil {
+			TLOG.Debugf("%s closed: %d, read %d, nil buff: %d, err: %v", t.server.config.Address, atomic.LoadInt32(&t.server.isClosed), n, len(currBuffer), err)
 			if atomic.LoadInt32(&t.server.isClosed) == 1 && currBuffer == nil {
 				return
 			}