Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger notices with non-string log messages #1512

Merged
merged 3 commits into from
Jun 24, 2023
Merged

Fix logger notices with non-string log messages #1512

merged 3 commits into from
Jun 24, 2023

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Jun 24, 2023

glensc added 3 commits June 24, 2023 20:44
@glensc
Add test for logger
19a9944 
Currently rest results inspected manually
@glensc
Refactor: Use formatMessage to override formatter
7978bf7 
Let super().format() do the str() of the record.msg
@glensc
Pre-compile logger pattern
41d9254
@glensc glensc self-assigned this Jun 24, 2023
@glensc glensc mentioned this pull request Jun 24, 2023
Merged
@glensc glensc merged commit bb62b74 into Taxel:main Jun 24, 2023
@glensc glensc deleted the fix-logger-filter branch June 24, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc