Skip to content

Commit

Permalink
πŸš€ :: 2.2.4
Browse files Browse the repository at this point in the history
  • Loading branch information
parkuiery authored Oct 26, 2024
2 parents 948eed5 + b9506b1 commit 668938c
Show file tree
Hide file tree
Showing 41 changed files with 197 additions and 190 deletions.
75 changes: 10 additions & 65 deletions .github/workflows/android-production-deploy-play-store.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,72 +79,17 @@ jobs:
prerelease: false

- name: Notify Discord on Success
if: ${{ success() }}
if: success()
id: discord-success
uses: Ilshidur/[email protected]
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK_URL }}
DISCORD_USERNAME: 깑톡 λ‘œμΌ“
DISCORD_EMBEDS: |
[
{
"title": "πŸš€ 앱이 λ°°ν¬λ˜μ—ˆμŠ΅λ‹ˆλ‹€.",
"color": "#36a64f",
"description": "https://github.com/${{github.repository}}",
"fields": [
{
"name": "Repository",
"value": "${{ github.repository }}",
"inline": true
},
{
"name": "Tag",
"value": "${{ github.ref_name }}",
"inline": true
},
{
"name": "Version",
"value": "${{ steps.get_tag.outputs.name }}",
"inline": true
},
{
"name": "Release Note",
"value": "${{ env.RELEASE_NOTE }}",
"inline": false
},
]
}
]
run: |
curl -H "Content-Type: application/json" \
-d '{"content": "πŸš€ 앱이 λ°°ν¬λ˜μ—ˆμŠ΅λ‹ˆλ‹€.\nTag: ${{ github.ref_name }}\n Version: ${{ steps.get_tag.outputs.name }}\nRelease Note: ${{ env.RELEASE_NOTE }}"}' \
${{ secrets.DISCORD_WEBHOOK_URL }}
- name: Notify Discord on Failure
if: ${{ failure() }}
id: discord-failure
uses: Ilshidur/[email protected]
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK_URL }}
DISCORD_USERNAME: 깑톡 λ‘œμΌ“
DISCORD_EMBEDS: |
[
{
"title": "πŸ’£ μ•± 배포에 μ‹€νŒ¨ν–ˆμ–΄μš” γ… γ… ",
"color": "#ff0000",
"description": "https://github.com/${{github.repository}}",
"fields": [
{
"name": "Repository",
"value": "${{ github.repository }}",
"inline": true
},
{
"name": "Tag",
"value": "${{ github.ref_name }}",
"inline": true
},
{
"name": "Version",
"value": "${{ steps.get_tag.outputs.name }}",
"inline": true
},
]
}
]
if: failure()
run: |
curl -H "Content-Type: application/json" \
-d '{"content": "πŸ’£ μ•± 배포에 μ‹€νŒ¨ν–ˆμ–΄μš” γ… γ… \nTag: ${{ github.ref_name }}\nVersion: ${{ steps.get_tag.outputs.name }}"}' \
${{ secrets.DISCORD_WEBHOOK_URL }}
4 changes: 2 additions & 2 deletions app/src/main/java/team/retum/jobisandroidv2/JobisNavigator.kt
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ internal class JobisNavigator(
navController.navigateToReportBug()
}

fun navigateToSearchRecruitment() {
navController.navigateToSearchRecruitment()
fun navigateToSearchRecruitment(isWinterIntern: Boolean) {
navController.navigateToSearchRecruitment(isWinterIntern = isWinterIntern)
}

fun navigateToNotificationSetting() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ fun NavGraphBuilder.root(
onRecruitmentDetailsClick: (Long) -> Unit,
onCompaniesClick: () -> Unit,
onRecruitmentFilterClick: () -> Unit,
onSearchRecruitmentClick: () -> Unit,
onSearchRecruitmentClick: (Boolean) -> Unit,
onNotificationSettingClick: () -> Unit,
onNoticeClick: () -> Unit,
onSelectInterestClick: () -> Unit,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ internal fun Root(
onRecruitmentDetailsClick: (Long) -> Unit,
onCompaniesClick: () -> Unit,
onRecruitmentFilterClick: () -> Unit,
onSearchRecruitmentClick: () -> Unit,
onSearchRecruitmentClick: (Boolean) -> Unit,
onNotificationSettingClick: () -> Unit,
onNoticeClick: () -> Unit,
onSelectInterestClick: () -> Unit,
Expand Down Expand Up @@ -115,7 +115,7 @@ private fun RootScreen(
onWinterInternClick: () -> Unit,
onRecruitmentDetailsClick: (Long) -> Unit,
onRecruitmentFilterClick: () -> Unit,
onSearchRecruitmentClick: () -> Unit,
onSearchRecruitmentClick: (Boolean) -> Unit,
showRejectionModal: (ApplicationData) -> Unit,
onCompaniesClick: () -> Unit,
onNotificationSettingClick: () -> Unit,
Expand Down
12 changes: 5 additions & 7 deletions app/src/main/play/release-notes/ko-KR/default.txt
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
[v2.2.3]
β€’ 버그 μˆ˜μ • 및 κΈ°λŠ₯을 μΆ”κ°€ν–ˆμ–΄μš”.
[v2.2.4]
β€’ 버그 μˆ˜μ • 및 데이터λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”.

[ μƒˆλ‘œμš΄ κΈ°λŠ₯ ]
β€’ μ²΄ν—˜ν˜• ν˜„μž₯μ‹€μŠ΅μ΄ μΆ”κ°€λ˜μ—ˆμ–΄μš”.
β€’ κ²¨μšΈμΈν„΄ μ•Œλ¦Όμ„ μΆ”κ°€ν–ˆμ–΄μš”.
-

[ κ°œμ„ λœ 점 ]
β€’ λ””μžμΈ μš”μ†Œλ₯Ό λ³€κ²½ν–ˆμ–΄μš”.
β€’ κΈ°μ—… 및 λͺ¨μ§‘μ˜λ’°μ„œμ˜ 데이터가 μˆ˜μ •λ˜μ—ˆμ–΄μš”.

[ 버그 μˆ˜μ • ]
β€’ 지원내역이 λ³΅μ‚¬λ˜λŠ” 버그λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”.
β€’ μΈμ¦μ½”λ“œ 전솑 버그λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”.
β€’ μ§€μ›ν˜„ν™©μ—μ„œ 사진이 μ•ˆλœ¨λŠ” 버그λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”.
β€’ 이메일이 μ „μ†‘λ˜μ§€ μ•ŠλŠ” 버그λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”.
4 changes: 2 additions & 2 deletions buildSrc/src/main/kotlin/ProjectProperties.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ object ProjectProperties {
const val COMPILE_SDK = 34
const val MIN_SDK = 28
const val TARGET_SDK = 34
const val VERSION_CODE = 17
const val VERSION_NAME = "2.2.3"
const val VERSION_CODE = 18
const val VERSION_NAME = "2.2.4"
const val COMPOSE_COMPILER_EXTENSION = "1.5.6"
const val JVM_TARGET = "18"
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ object ResourceKeys {
const val COMPANY_NAME = "companyName"
const val IS_MOVED_RECRUITMENT_DETAILS = "isMovedRecruitmentDetails"
const val IS_MOVED_COMPANY_DETAILS = "isMovedCompanyDetails"
const val IS_WINTER_INTERN = "isWinterIntern"
const val EMAIL = "@dsm.hs.kr"
const val DATABASE_NAME = "jobis-database"
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ interface UserRepository {

fun getRefreshExpiresAt(): String

fun signOut()
suspend fun signOut()

suspend fun saveDeviceToken(deviceToken: String)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ class UserRepositoryImpl @Inject constructor(
return localUserDataSource.getRefreshExpiresAt()
}

override fun signOut() {
override suspend fun signOut() {
remoteUserDataSource.deleteDeviceToken()
localUserDataSource.clearUserInformation()
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ import team.retum.jobisdesignsystemv2.foundation.JobisIcon
import team.retum.jobisdesignsystemv2.foundation.JobisTheme
import team.retum.jobisdesignsystemv2.foundation.JobisTypography
import team.retum.jobisdesignsystemv2.text.JobisText
import team.retum.jobisdesignsystemv2.utils.clickable

/**
* [JobisTextField]μ—μ„œ ν‘œμ‹œλ˜λŠ” description의 μ’…λ₯˜λ₯Ό κ²°μ •
Expand Down Expand Up @@ -100,6 +101,40 @@ private fun TextFieldTitle(
)
}

@Composable
private fun JobisVerificationButton(
modifier: Modifier = Modifier,
onVerificationClick: () -> Unit,
isSendAuthenticationCode: Boolean,
) {
Box(
modifier = modifier
.background(
color = JobisTheme.colors.primary,
shape = RoundedCornerShape(8.dp),
)
.padding(
horizontal = 8.dp,
vertical = 4.dp,
)
.clickable(
onClick = onVerificationClick,
),
) {
JobisText(
text = stringResource(
id = if (isSendAuthenticationCode) {
R.string.re_send_authentication_code
} else {
R.string.authentication
},
),
style = JobisTypography.Body,
color = JobisTheme.colors.onSurfaceVariant,
)
}
}

@Composable
private fun TextField(
modifier: Modifier = Modifier,
Expand All @@ -112,6 +147,9 @@ private fun TextField(
keyboardType: KeyboardType,
maxLength: Int,
showEmailHint: Boolean,
showVerificationButton: Boolean,
onVerificationClick: () -> Unit,
isSendAuthenticationCode: Boolean,
showVisibleIcon: Boolean,
@DrawableRes drawableResId: Int?,
content: @Composable () -> Unit,
Expand Down Expand Up @@ -193,6 +231,12 @@ private fun TextField(
color = JobisTheme.colors.onSurfaceVariant,
)
}
if (showVerificationButton) {
JobisVerificationButton(
onVerificationClick = onVerificationClick,
isSendAuthenticationCode = isSendAuthenticationCode,
)
}
content()
if (showVisibleIcon) {
JobisIconButton(
Expand Down Expand Up @@ -270,6 +314,9 @@ private fun Description(
* @param singleLine ν…μŠ€νŠΈ ν•„λ“œμ— 닀쀑 쀄을 ν—ˆμš©ν•  것인지 κ²°μ •
* @param maxLength ν…μŠ€νŠΈ ν•„λ“œ κ°’μ˜ μ΅œλŒ€ 길이
* @param showEmailHint 이메일 도메인에 λŒ€ν•œ 힌트λ₯Ό ν‘œμ‹œν•  것인지 κ²°μ •(e.g., @dsm.hs.kr).
* @param showVerificationButton 인증 λ²„νŠΌμ„ ν‘œμ‹œν•  것인지 κ²°μ •
* @param onVerificationClick 인증 λ²„νŠΌμ„ 클릭할 λ•Œ ν˜ΈμΆœλ˜λŠ” ν•¨μˆ˜
* @param isSendAuthenticationCode 인증 μ—¬λΆ€
* @param showVisibleIcon λΉ„λ°€λ²ˆν˜Έ ν‘œμ‹œ
* @param drawableResId ν…μŠ€νŠΈ ν•„λ“œμ— ν‘œμ‹œλ  μ•„μ΄μ½˜
* @param fieldColor λ°°κ²½ 색상
Expand Down Expand Up @@ -316,6 +363,9 @@ fun JobisTextField(
singleLine: Boolean = true,
maxLength: Int = Int.MAX_VALUE,
showEmailHint: Boolean = false,
showVerificationButton: Boolean = false,
onVerificationClick: () -> Unit = { },
isSendAuthenticationCode: Boolean = false,
showVisibleIcon: Boolean = false,
@DrawableRes drawableResId: Int? = null,
fieldColor: Color = JobisTheme.colors.inverseSurface,
Expand Down Expand Up @@ -352,6 +402,9 @@ fun JobisTextField(
keyboardType = keyboardType,
maxLength = maxLength,
showEmailHint = showEmailHint,
showVerificationButton = showVerificationButton,
onVerificationClick = onVerificationClick,
isSendAuthenticationCode = isSendAuthenticationCode,
showVisibleIcon = showVisibleIcon,
drawableResId = drawableResId,
content = content,
Expand Down
2 changes: 2 additions & 0 deletions core/design-system/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,6 @@
<string name="content_description_search">κ²€μƒ‰ν•˜κΈ°</string>
<string name="content_description_jobis">μ•± λ°” 둜고</string>
<string name="content_description_information">정보</string>
<string name="authentication">인증 ν•˜κΈ°</string>
<string name="re_send_authentication_code">μž¬λ°œμ†‘</string>
</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,21 @@ data class RecruitmentDetailsEntity(
val companyProfileUrl: String,
val companyName: String,
val areas: List<AreasEntity>,
val requiredGrade: Long?,
val additionalQualifications: String?,
val workingHours: String,
val requiredLicenses: List<String>?,
val hiringProgress: List<HiringProgress>,
val trainPay: Long,
val pay: String?,
val benefits: String?,
val military: Boolean,
val militarySupport: Boolean,
val submitDocument: String,
val startDate: String?,
val endDate: String?,
val etc: String?,
val isApplicable: Boolean,
val bookmarked: Boolean,
val winterIntern: Boolean,
)

@Immutable
Expand Down Expand Up @@ -55,20 +56,21 @@ internal fun FetchRecruitmentDetailsResponse.toEntity() = RecruitmentDetailsEnti
companyProfileUrl = ResourceKeys.IMAGE_URL + this.companyProfileUrl,
companyName = this.companyName,
areas = this.areas.map { it.toEntity() },
requiredGrade = this.requiredGrade,
additionalQualifications = this.additionalQualifications,
workingHours = this.workingHours,
requiredLicenses = this.requiredLicenses,
hiringProgress = this.hiringProgress,
trainPay = this.trainPay,
pay = this.pay,
benefits = this.benefits,
military = this.military,
militarySupport = this.militarySupport,
submitDocument = this.submitDocument,
startDate = this.startDate,
endDate = this.endDate,
etc = this.etc,
isApplicable = this.isApplicable,
bookmarked = this.bookmarked,
winterIntern = this.winterIntern,
)

private fun Areas.toEntity() = AreasEntity(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,8 @@ data class CompanyDetailsEntity(
val companyProfileUrl: String,
val companyIntroduce: String,
val mainAddress: String?,
val subAddress: String?,
val managerName: String?,
val managerPhoneNo: String?,
val subManagerName: String?,
val subManagerPhoneNo: String?,
val fax: String?,
val representativePhoneNo: String?,
val email: String?,
val representativeName: String?,
val foundedAt: String,
Expand All @@ -47,6 +43,7 @@ data class CompanyDetailsEntity(
val attachments: List<String>?,
val serviceName: String?,
val businessArea: String?,
val headquarter: Boolean,
)

fun FetchCompanyDetailsResponse.toEntity() = CompanyDetailsEntity(
Expand All @@ -55,12 +52,8 @@ fun FetchCompanyDetailsResponse.toEntity() = CompanyDetailsEntity(
companyProfileUrl = ResourceKeys.IMAGE_URL + this.companyProfileUrl,
companyIntroduce = this.companyIntroduce,
mainAddress = "${this.mainAddress} ${this.mainAddressDetail}",
subAddress = this.subAddress?.apply { plus(this@toEntity.subAddressDetail) },
managerName = this.managerName,
managerPhoneNo = this.managerPhoneNo?.toPhoneNumber(),
subManagerName = this.subManagerName,
subManagerPhoneNo = this.subManagerPhoneNo?.toPhoneNumber(),
fax = this.fax,
representativePhoneNo = this.representativePhoneNo?.toPhoneNumber(),
email = this.email,
representativeName = this.representativeName,
foundedAt = this.foundedAt,
Expand All @@ -70,6 +63,7 @@ fun FetchCompanyDetailsResponse.toEntity() = CompanyDetailsEntity(
attachments = this.attachments,
serviceName = this.serviceName,
businessArea = this.businessArea,
headquarter = this.headquarter,
)

private fun Double.toTake(): String {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package team.retum.usecase.usecase.auth

import team.retum.common.utils.ResourceKeys
import team.retum.data.repository.auth.AuthRepository
import javax.inject.Inject

Expand All @@ -12,7 +11,7 @@ class AuthorizeAuthenticationCodeUseCase @Inject constructor(
authCode: String,
) = runCatching {
authRepository.authorizeAuthenticationCode(
email = email + ResourceKeys.EMAIL,
email = email,
authCode = authCode,
)
}
Expand Down
Loading

0 comments on commit 668938c

Please sign in to comment.