Skip to content

Commit

Permalink
๐Ÿš€ :: v2.0.7
Browse files Browse the repository at this point in the history
  • Loading branch information
Tmdhoon2 committed Apr 18, 2024
2 parents 9d63786 + e074915 commit 9d884e1
Show file tree
Hide file tree
Showing 15 changed files with 150 additions and 38 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules โ€ฆ
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.* @Team-return/jobis-android
11 changes: 10 additions & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@ android {

buildTypes {
release {
isMinifyEnabled = false
isMinifyEnabled = true
isShrinkResources = true
proguardFiles(
getDefaultProguardFile("proguard-android-optimize.txt"),
"proguard-rules.pro",
)
}
debug {
isMinifyEnabled = true
isShrinkResources = true
proguardFiles(
getDefaultProguardFile("proguard-android-optimize.txt"),
"proguard-rules.pro",
Expand Down
97 changes: 97 additions & 0 deletions app/proguard-rules.pro
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
# Add project specific ProGuard rules here.
# You can control the set of applied configuration files using the
# proguardFiles setting in build.gradle.
#
# For more details, see
# http://developer.android.com/guide/developing/tools/proguard.html

# If your project uses WebView with JS, uncomment the following
# and specify the fully qualified class name to the JavaScript interface
# class:
#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
# public *;
#}

# Uncomment this to preserve the line number information for
# debugging stack traces.
#-keepattributes SourceFile,LineNumberTable

# If you keep the line number information, uncomment this to
# hide the original source file name.
#-renamesourcefileattribute SourceFile

# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class team.** { *; }

# keep everything in this package from being renamed only
-keepnames class team.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class okhttp3.** { *; }

# keep everything in this package from being renamed only
-keepnames class okhttp3.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class kotlin.** { *; }

# keep everything in this package from being renamed only
-keepnames class kotlin.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class okio.** { *; }

# keep everything in this package from being renamed only
-keepnames class okio.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class java.** { *; }

# keep everything in this package from being renamed only
-keepnames class java.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class retrofit2.** { *; }

# keep everything in this package from being renamed only
-keepnames class retrofit2.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class org.** { *; }

# keep everything in this package from being renamed only
-keepnames class org.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class javax.** { *; }

# keep everything in this package from being renamed only
-keepnames class javax.** { *; }
# Add *one* of the following rules to your Proguard configuration file.
# Alternatively, you can annotate classes and class members with @androidx.annotation.Keep

# keep everything in this package from being removed or renamed
-keep class _COROUTINE.** { *; }

# keep everything in this package from being renamed only
-keepnames class _COROUTINE.** { *; }
4 changes: 2 additions & 2 deletions buildSrc/src/main/kotlin/ProjectProperties.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ object ProjectProperties {
const val COMPILE_SDK = 34
const val MIN_SDK = 28
const val TARGET_SDK = 34
const val VERSION_CODE = 8
const val VERSION_NAME = "2.0.6"
const val VERSION_CODE = 9
const val VERSION_NAME = "2.0.7"
const val COMPOSE_COMPILER_EXTENSION = "1.5.6"
const val JVM_TARGET = "18"
}
1 change: 0 additions & 1 deletion feature/change-password/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<string name="title_reset_password">์ƒˆ๋กœ ์‚ฌ์šฉํ• \n๋น„๋ฐ€๋ฒˆํ˜ธ๋ฅผ ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”</string>
<string name="password">๋น„๋ฐ€๋ฒˆํ˜ธ</string>
<string name="hint_password">๊ณ„์ •์˜ ๋น„๋ฐ€๋ฒˆํ˜ธ๋ฅผ ์„ค์ •ํ•ด์ฃผ์„ธ์š”</string>
<string name="information_password">8 ~ 16์ž, ์˜๋ฌธ์ž, ์ˆซ์ž, ํŠน์ˆ˜๋ฌธ์ž ํฌํ•จ</string>
<string name="check_password">๋น„๋ฐ€๋ฒˆํ˜ธ ํ™•์ธ</string>
<string name="hint_check_password">์œ„ ๋น„๋ฐ€๋ฒˆํ˜ธ๋ฅผ ํ•œ ๋ฒˆ ๋” ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”</string>
<string name="complete">์™„๋ฃŒ</string>
Expand Down
3 changes: 0 additions & 3 deletions feature/home/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="employment_rate">%s๊ธฐ ๋Œ€๋งˆ๊ณ \nํ•™์ƒ๋“ค์˜ ์ทจ์—…</string>
<string name="employment_rate_current">ํ˜„์žฌ %s๋ช…์ด ์ทจ์—…ํ–ˆ์–ด์šฉ</string>

<string name="search_other_companies">๋‹ค๋ฅธ ๊ธฐ์—…๋“ค\nํƒ์ƒ‰ํ•˜๊ธฐ</string>
<string name="experiential_field_training">์ฒดํ—˜ํ˜• \nํ˜„์žฅ์‹ค์Šต</string>
<string name="how_about_other_companies">๋‹ค๋ฅธ ๊ธฐ์—…๋“ค์€ ์–ด๋–จ๊นŒ?\n๋‹ค๋ฅธ ๊ธฐ์—…๋“ค ๋‘˜๋Ÿฌ ๋ณด๋Ÿฌ ๊ฐ€๊ธฐ</string>

Expand All @@ -13,7 +11,6 @@
<string name="description_apply_status">์Šน์ธ์š”์ฒญ ๋ฐ ๋ฐ˜๋ ค ์ƒํƒœ์—” ์žฌ์ง€์› ๊ฐ€๋Šฅ</string>
<string name="empty_apply_companies">ํ˜„์žฌ ์ง€์›ํ•œ ๊ธฐ์—…์ด ์—†์–ด์š”</string>

<string name="reason">์‚ฌ์œ  ๋ณด๊ธฐ</string>
<string name="reason_rejection">๋ฐ˜๋ ค ์‚ฌ์œ </string>
<string name="re_apply">์žฌ์ง€์› ํ•˜๊ธฐ</string>

Expand Down
1 change: 0 additions & 1 deletion feature/mypage/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<string name="membership_withdrawal">ํšŒ์› ํƒˆํ‡ด</string>
<string name="bug_report">๋ฒ„๊ทธ ์ œ๋ณด</string>
<string name="to_bug_report">๋ฒ„๊ทธ ์ œ๋ณดํ•˜๊ธฐ</string>
<string name="bug_report_box">๋ฒ„๊ทธ ์ œ๋ณดํ•จ</string>
<string name="write_interview_review">๋ฉด์ ‘ ํ›„๊ธฐ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”!</string>
<string name="go_write">์ž‘์„ฑํ•˜๋Ÿฌ ๊ฐ€๊ธฐ โ†’</string>
<string name="sign_out_modal_title">JOBIS์—์„œ ๋กœ๊ทธ์•„์›ƒ ํ•˜์‹œ๊ฒ ์–ด์š”?</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ private fun BottomBar(
id = if (isApplicable) {
R.string.apply
} else {
R.string.can_do_apply_third
R.string.can_do_not_apply
},
),
style = JobisTypography.SubHeadLine,
Expand Down Expand Up @@ -457,7 +457,11 @@ private fun BottomBar(
},
),
contentDescription = "bookmark",
tint = JobisTheme.colors.onPrimary,
tint = if (isBookmark) {
JobisTheme.colors.onPrimary
} else {
JobisTheme.colors.onSurfaceVariant
},
)
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package team.retum.jobis.recruitment.ui.component

import androidx.annotation.DrawableRes
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
Expand Down Expand Up @@ -48,11 +47,7 @@ internal fun RecruitmentItems(
RecruitmentItem(
recruitment = recruitment,
onClick = onRecruitmentClick,
bookmarkIcon = if (bookmarked) {
JobisIcon.BookmarkOn
} else {
JobisIcon.BookmarkOff
},
bookmarked = bookmarked,
onBookmarked = {
onBookmarkClick(it)
bookmarked = !bookmarked
Expand All @@ -69,7 +64,7 @@ internal fun RecruitmentItems(
private fun RecruitmentItem(
recruitment: RecruitmentsEntity.RecruitmentEntity,
onClick: (recruitId: Long) -> Unit,
@DrawableRes bookmarkIcon: Int,
bookmarked: Boolean,
onBookmarked: (recruitId: Long) -> Unit,
) {
val whetherMilitarySupported = when (recruitment.militarySupport) {
Expand Down Expand Up @@ -149,10 +144,20 @@ private fun RecruitmentItem(
Spacer(modifier = Modifier.width(4.dp))
JobisIconButton(
modifier = Modifier.padding(4.dp),
painter = painterResource(id = bookmarkIcon),
painter = painterResource(
id = if (bookmarked) {
JobisIcon.BookmarkOn
} else {
JobisIcon.BookmarkOff
},
),
contentDescription = "bookmark",
onClick = { onBookmarked(recruitment.id) },
tint = JobisTheme.colors.onPrimary,
tint = if (bookmarked) {
JobisTheme.colors.onPrimary
} else {
JobisTheme.colors.onSurfaceVariant
},
)
}
}
13 changes: 0 additions & 13 deletions feature/recruitment/src/main/res/drawable/ic_arrow_up.xml

This file was deleted.

4 changes: 1 addition & 3 deletions feature/recruitment/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

<string name="military_supported">๋ณ‘์—ญํŠน๋ก€ O</string>
<string name="military_not_supported">๋ณ‘์—ญํŠน๋ก€ X</string>
<string name="train_pay">์‹ค์Šต ์ˆ˜๋‹น</string>

<string name="recruitment_no_content">๊ฒ€์ƒ‰์–ด์™€ ๊ด€๋ จ๋œ ๋ชจ์ง‘์˜๋ขฐ์„œ๋ฅผ ๋ชป ์ฐพ์•˜์–ด์š”</string>
<string name="retry">์ œ๋Œ€๋กœ ์ž…๋ ฅํ–ˆ๋Š”์ง€ ๋‹ค์‹œ ํ•œ ๋ฒˆ ํ™•์ธํ•ด์ฃผ์„ธ์š”</string>
Expand All @@ -20,12 +19,11 @@
<string name="recruitment_procedure">์ฑ„์šฉ์ ˆ์ฐจ</string>
<string name="required_grade">ํ•„์ˆ˜ ์„ฑ์ </string>
<string name="work_hours">๊ทผ๋ฌด์‹œ๊ฐ„</string>
<string name="convert_to_full_time_job">์ •๊ทœ์ง ์ „ํ™˜ ์‹œ</string>
<string name="wage_and_benefits">๋ณต๋ฆฌํ›„์ƒ</string>
<string name="submission_document">์ œ์ถœ ์„œ๋ฅ˜</string>
<string name="etc">๊ธฐํƒ€ ์‚ฌํ•ญ</string>
<string name="apply">์ง€์›ํ•˜๊ธฐ</string>
<string name="can_do_apply_third">3ํ•™๋…„๋งŒ ์ง€์›ํ•  ์ˆ˜ ์žˆ์–ด์š”</string>
<string name="can_do_not_apply">์ง€์›ํ•  ์ˆ˜ ์—†์–ด์š”</string>
<string name="major_task">์ฃผ์š” ์—…๋ฌด</string>

<string name="occurred_error">์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ–ˆ์Šต๋‹ˆ๋‹ค</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ private fun InputEmailScreen(
showAuthenticationCodeDescription = { state.showAuthenticationCodeDescription },
sendAuthenticationCode = { state.sendAuthenticationCode },
remainTime = state.remainTime,
isResend = { state.isResend },
)
Spacer(modifier = Modifier.weight(1f))
JobisButton(
Expand All @@ -127,14 +128,21 @@ private fun EmailInputs(
showAuthenticationCodeDescription: () -> Boolean,
sendAuthenticationCode: () -> Boolean,
remainTime: String,
isResend: () -> Boolean,
) {
JobisTextField(
title = stringResource(id = R.string.email),
value = email,
hint = stringResource(id = R.string.hint_email),
onValueChange = onEmailChange,
showEmailHint = true,
checkDescription = stringResource(id = R.string.description_email_sent),
checkDescription = stringResource(
id = if (isResend()) {
R.string.description_email_re_send
} else {
R.string.description_email_sent
},
),
errorDescription = stringResource(id = R.string.description_conflict_email),
showDescription = showEmailDescription,
descriptionType = emailDescriptionType,
Expand All @@ -150,6 +158,7 @@ private fun EmailInputs(
color = ButtonColor.Secondary,
onClick = onAuthenticationClick,
keyboardInteractionEnabled = false,
enabled = email().isNotEmpty(),
)
}
JobisTextField(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ internal class InputEmailViewModel @Inject constructor(
) : BaseViewModel<InputEmailState, InputEmailSideEffect>(InputEmailState.getDefaultState()) {

private val timerUtil: TimerUtil = TimerUtil()
private var authenticationClickCount: Int = 0

internal fun onNextClick() {
setState { state.value.copy(buttonEnabled = false) }
Expand Down Expand Up @@ -82,6 +83,10 @@ internal class InputEmailViewModel @Inject constructor(
showEmailDescription = true,
)
}
if (authenticationClickCount > 0) {
setState { state.value.copy(isResend = true) }
}
authenticationClickCount++
}.onFailure {
when (it) {
is BadRequestException -> {
Expand Down Expand Up @@ -134,6 +139,7 @@ internal data class InputEmailState(
val buttonEnabled: Boolean,
val sendAuthenticationCode: Boolean,
val remainTime: String,
val isResend: Boolean,
) {
companion object {
fun getDefaultState() = InputEmailState(
Expand All @@ -145,6 +151,7 @@ internal data class InputEmailState(
buttonEnabled = false,
sendAuthenticationCode = false,
remainTime = "5:00",
isResend = false,
)
}
}
Expand Down
3 changes: 2 additions & 1 deletion feature/signup/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@
<string name="authentication_code">์ธ์ฆ์ฝ”๋“œ</string>

<string name="authentication">์ธ์ฆ ํ•˜๊ธฐ</string>
<string name="re_send_authentication_code">์žฌ์ „์†ก</string>
<string name="re_send_authentication_code">์žฌ๋ฐœ์†ก</string>

<string name="hint_email">example</string>
<string name="hint_authentication_code">์ด๋ฉ”์ผ๋กœ ์˜จ ์ฝ”๋“œ๋ฅผ ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”</string>

<string name="description_email_sent">์ธ์ฆ ๋ฉ”์ผ์ด ๋ฐœ์†ก๋˜์—ˆ์–ด์š”</string>
<string name="description_email_re_send">์ธ์ฆ ๋ฉ”์ผ์ด ์žฌ๋ฐœ์†ก๋˜์—ˆ์–ด์š”</string>
<string name="description_conflict_email">์ด๋ฏธ ๊ฐ€์ž… ๋œ ์ด๋ฉ”์ผ์ด์—์š”</string>
<string name="toast_check_email_validation">์ด๋ฉ”์ผ ํ˜•์‹์„ ํ™•์ธํ•ด์ฃผ์„ธ์š”</string>

Expand Down
1 change: 0 additions & 1 deletion feature/verify-email/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<resources>
<string name="title_change_password">๋น„๋ฐ€๋ฒˆํ˜ธ ๋ณ€๊ฒฝ์„ ์œ„ํ•ด\n์ด๋ฉ”์ผ์„ ์ธ์ฆํ•ด์ฃผ์„ธ์š”</string>
<string name="email">์ด๋ฉ”์ผ</string>
<string name="authorize">์ธ์ฆ ํ•˜๊ธฐ</string>
<string name="authentication_code">์ธ์ฆ ์ฝ”๋“œ</string>
<string name="hint_email">example</string>
<string name="hint_authentication_code">์ด๋ฉ”์ผ๋กœ ์˜จ ์ฝ”๋“œ๋ฅผ ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”</string>
Expand Down

0 comments on commit 9d884e1

Please sign in to comment.