Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

공지 작성 페이지 퍼블리싱 #41

Closed
wants to merge 2 commits into from

Conversation

eejx0
Copy link
Contributor

@eejx0 eejx0 commented Feb 21, 2024

특이사항

  • 공지 작성 페이지 퍼블리싱

관련 이슈

@eejx0 eejx0 added the 기능 구현 구현, 개선 사항에 관련된 내용입니다. label Feb 21, 2024
@eejx0 eejx0 requested review from JJIIIINN and dnjsdmswl February 21, 2024 12:49
@eejx0 eejx0 self-assigned this Feb 21, 2024
@eejx0 eejx0 linked an issue Feb 21, 2024 that may be closed by this pull request

const onInputHandler = (e: any) => {
setInputCount(e.target.value.length);
console.log(inputCount)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1) 지워주세요.

maxLength={1000}
>
</TextInput>
<div style={{fontSize: '16px', fontWeight: '500', marginLeft: 'auto'}}>{inputCount}/1000</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1) 인라인 스타일로 쓰기에는 속성이 많은 것 같아요.

Comment on lines +65 to +170
justify-content: center;
align-items: center;
background-color: white;
`;

const Title = styled.div`
font-weight: 600;
font-size: 23px;
line-height: 36px;
margin-left: 24px;
align-self: flex-start;
margin-bottom: 25px;
`;

const ContentWrap = styled.div`
display: flex;
flex-direction: column;
gap: 30px;
justify-content: center;
align-items: flex-start;
text-align: left;
`;

const WriteDateWrap = styled.div`
display: flex;
flex-direction: row;
gap: 56px;
align-items: center;
`;

const Text = styled.div`
font-size: 23px;
font-weight: 600;
`;

const TitleWrap = styled.div`
display: flex;
flex-direction: row;
gap: 80px;
align-items: center;
`;

const Input = styled.input`
width: 545px;
height: 43px;
border: 1px solid #999999;
padding-left: 10px;
font-size: 16px;
border-radius: 4px;
`;

const TextWrap = styled.div`
display: flex;
flex-direction: row;
gap: 80px;
`;

const InputWrapper = styled.div`
width: 545px;
height: 400px;
border: 1px solid #999999;
border-radius: 4px;
padding: 10px;
overflow: auto;
background-color: white;
display: flex;
flex-direction: column;
`;

const TextInput = styled.textarea`
width: 100%;
height: 90%;
font-size: 16px;
border: none;
resize: none;
`;

const FileWrap = styled.div`
display: flex;
flex-direction: row;
gap: 37px;
align-items: center;
`;

const AddFile = styled.div`
width: 550px;
height: 43px;
background-color: #FAFAFA;
cursor: pointer;
font-size: 16px;
align-items: center;
display: flex;
padding-left: 16px;
font-weight: 400;
`;

const ButtonWrap = styled.div`
margin-top: 68px;
margin-left: auto;
`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1) 스타일 파일로 옮겨주세요.

@JJIIIINN
Copy link
Member

p1) 전체적으로 디자인 시스템을 안 쓰고 있는데 한 번 써보면 좋을 것 같아요.

@eejx0 eejx0 closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 구현 구현, 개선 사항에 관련된 내용입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

공지 작성 퍼블리싱
3 participants