Migrate to non-transitive R classes #10077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Non_transitive_R
branch
2 times, most recently
from
8f91e86 to
ddc6634
Compare
|
SonarCloud Quality Gate failed. |
Isira-Seneviratne
changed the title
|
The SonarCloud warnings are due to the app using private ExoPlayer strings. |
SameenAhnaf
added
the
codequality
Profpatsch
force-pushed
the
Non_transitive_R
branch
from
ddc6634 to
097d32b
Compare
|
Thank you, I rebased the change onto current |
|
|
How did you choose the replacements? To me they all seem random. For example, why |
Stypox
reviewed
Mar 28, 2024
| @@ -54,7 +54,11 @@ class ErrorUtil { | |||
| */ | |||
| @JvmStatic | |||
| fun showSnackbar(context: Context, errorInfo: ErrorInfo) { | |||
| val rootView = if (context is Activity) context.findViewById<View>(R.id.content) else null | |||
| val rootView = if (context is Activity) { | |||
| context.findViewById<View>(androidx.constraintlayout.widget.R.id.content) | |||
There was a problem hiding this comment.
For example, this is wrong, and should instead be android.R.id.content.
5 tasks
|
Replaced by #10918 for the reasons stated above. @Isira-Seneviratne please review/approve #10918, thanks :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence