Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR labeler permissions #10455

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix PR labeler permissions #10455

merged 1 commit into from
Sep 27, 2023

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Sep 27, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Although the permission to modify PRs is granted to the entire workflow, the job still reports that it does not the permission to do so:

GITHUB_TOKEN Permissions
  Contents: read
  Metadata: read
  PullRequests: read

This adds the permission to the job directly.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Although the permission to modify PRs is granted to the entire workflow, the job still reports that it does not the permission to do so:
GITHUB_TOKEN Permissions
  Contents: read
  Metadata: read
  PullRequests: read
This adds the permission to the job directly
@TobiGr TobiGr added the meta Related to the project but not strictly to code label Sep 27, 2023
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Sep 27, 2023
@TobiGr TobiGr merged commit fe7d169 into dev Sep 27, 2023
2 of 6 checks passed
@TobiGr TobiGr deleted the pr-labeler branch September 27, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant