SubscriptionsImportFragment: Inline setup stuff

[Profpatsch]

Very small simplification

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Due diligence

• I read the contribution guidelines.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acrodemocide]

I know this was originally set based on the function that was removed, but, if I recall correctly, a declared String in Java is already null, so this assignment is not needed.

[Profpatsch]

Probably, but this just inlines the existing code, which I don’t want to change here.

[Stypox]

Yeah there's no problem in making it explicit that it's initialized to null

[Stypox]

Sorry, I just realized that according to Android fragment lifecycle, the onCreate function might be called multiple times, so this PR actually does change semantics. I would not risk making this change right before the rewrite, as we want to ship as stable of a release as possible. However, it's true that the setupServiceVariables method could be inlined, but it's not too important, and will probably be rewritten sooner or later anyway.