Settings redesign debug page #10876
Settings redesign debug page #10876
Conversation
|
|
Never mind. That's what #10849 is for. |
Thanks for checking out the work. You're absolutely correct. This PR focuses on laying the groundwork for Jetpack Compose in the settings page. We're currently waiting for feedback on theme and color design choices. This feedback might influence the overall implementation details. Once the design aspects are reviewed and approved, we'll proceed with building the rest of the settings page functionality. Regarding PR #10849, that branch holds the previous implementation without Jetpack Compose. We've kept it open temporarily for reference until this PR with the Compose approach receives some reviews. After we have a clearer direction, we'll close PR #10849. |
Where is this taking place? |
I had only pinged in the Matrix room. |
|
@snaik20 if you want, you can start to develop the Jetpack Compose components for settings screen. This will be our first step toward rewriting :-D |
snaik20
force-pushed
the
settings-redesign-debug-page
branch
from
efc8775 to
acc1293
Compare
Updated the PR to add a working SwitchPreference. The plan ahead is to add other components similarly in followup PRs and integrate the Settings page altogether. |
snaik20
force-pushed
the
settings-redesign-debug-page
branch
3 times, most recently
from
981fd9f to
6f06ceb
Compare
snaik20
force-pushed
the
settings-redesign-debug-page
branch
from
6f06ceb to
b1d8f59
Compare
|
|
Is this just waiting for review or is there something left to be done? |
Waiting for final review and approval |
|
This PR looks good to me overall. Better include some previews as well, that way the UI doesn't have to be deployed to be viewed. |
|
Wow. I didn't even know you could assign a PR author to their own PR. |
|
They were already assigned, I accidentally changed the assignment while going through the project UI. |
snaik20
force-pushed
the
settings-redesign-debug-page
branch
from
b1d8f59 to
5a8adba
Compare
- Implemented a new settings page using Jetpack Compose. - Added a new settings option to enable the redesigned settings page. - This option allows for gradual integration and testing of the new settings page, minimizing disruptions to current functionality. Plan for Settings Items: - Jetpack Compose does not have a direct equivalent to the Preference/settings library. - We could consider using third-party libraries that offer preference items as composables. - However, these libraries may be incomplete or lack active development. - Given our specific needs for only a subset of preference types, creating custom composables would be beneficial. - This approach allows for fine-tuning the components to our specific use case.
snaik20
force-pushed
the
settings-redesign-debug-page
branch
from
5a8adba to
73520e0
Compare
|
This comment was marked as spam.
This comment was marked as spam.
What is it?
Description of the changes in your PR
Initial Work for Settings Page with Jetpack Compose
settings page, minimizing disruptions to current functionality.
Plan for Settings Items:
Preference/settings library.
items as composables.
creating custom composables would be beneficial.
use case.
Next Steps:
functionalities and screens.
Fixes the following issue(s)
Screenshots/Videos
NewPipe_Settings_Debug_Part1.mp4
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence