Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use groupingBy collector in ListHelper #10904

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Use the groupingBy collector in the ListHelper class.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added codequality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines labels Mar 24, 2024
Copy link

@Stypox
Copy link
Member

Stypox commented Mar 28, 2024

I'm sorry, but I think the previous code was just fine. The new code is less understandable, and hides some important implementation details that may cause crashes, e.g. the fact that the map returned by .collect(groupingBy()) might not support .remove() (the documentation says it's a normal Map although from my testing it's a HashMap).

@Stypox Stypox closed this Mar 28, 2024
@Isira-Seneviratne Isira-Seneviratne deleted the Use-Collectors-grouping branch July 27, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants