Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image loading due to a missing library in PR migrate build to version catalogs #11750

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Nov 26, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fix the image loading by adding the Coil OkHttp integration library.
  • Update Coil to 3.0.4 (changelog).
  • Reuse the OkHttpClient created in DownloaderImpl in the image loader for improved efficiency.

Fixes the following issue(s)

Reason of the regression

  • Coil 3 doesn't load network images by default (it needs one of the integration libraries to do so, which I included in the earlier PR 11723).

  • coil-network-okhttp = { group = "io.coil-kt.coil3", name = 'coil-network-okhttp', version.ref = "coil" }

  • The library misses inclusion in the version catalogs PR Migrate build to version catalogs #11684 and it was merged into refactor branch causing the regression.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Nov 26, 2024
@ShareASmile ShareASmile added bug Issue is related to a bug dependency Issues and PRs related to dependencies rewrite Issues and PRs related to rewrite labels Nov 26, 2024
@Stypox
Copy link
Member

Stypox commented Nov 26, 2024

Can you give more information on the bug? Why was this not happening in #11723 and what caused it to appear?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Nov 26, 2024

Can you give more information on the bug? Why was this not happening in #11723 and what caused it to appear?

Coil 3 doesn't load network images by default (it needs one of the integration libraries to do so, which I included in the earlier PR).

coil-network-okhttp = { group = "io.coil-kt.coil3", name = 'coil-network-okhttp', version.ref = "coil" }

The library wasn't present in the version catalog after #11684 was merged.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing!

@Stypox Stypox merged commit dab0148 into TeamNewPipe:refactor Nov 27, 2024
7 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Fix-image-loading branch November 28, 2024 00:30
@ShareASmile ShareASmile changed the title Fix image loading Fix image loading due to a missing library in PR migrate build to version catalogs Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug dependency Issues and PRs related to dependencies rewrite Issues and PRs related to rewrite size/small PRs with less than 50 changed lines
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants