Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a high-resolution option in the default resolution settings. #9987

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Include a high-resolution option in the default resolution settings. #9987

merged 2 commits into from
Sep 24, 2023

Conversation

Edwardsoen
Copy link
Contributor

@Edwardsoen Edwardsoen commented Mar 30, 2023 •
edited by Stypox
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • When "Show higher resolution" option is enabled, add 1440p and 2160p option to "Default resolution", "Default popup resolution" and "Limit resolution when using mobile data"
  • switch to "Best resolution" and "No limit" when "Show higher resolution" is disabled and 1440p or 2160p is iselected

Before/After Screenshots/Screen Record

Before After
Before After

Fixes the following issue(s)

Due diligence

@SameenAhnaf SameenAhnaf added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Mar 30, 2023
@Edwardsoen
Copy link
Contributor Author

looks like CI failed with "Could not find com.github.TeamNewPipe:NewPipeExtractor" error. not sure whats going on, i didnt change any gradle files and my CI run on my forked repository also failed with both dev and master branch.....

@halfbytecode halfbytecode mentioned this pull request Apr 5, 2023
Closed
5 tasks
@opusforlife2
Copy link
Collaborator

Could you resolve the conflicts? Then I can re-run the tests.

@Edwardsoen
Copy link
Contributor Author

conflict resolved

@Edwardsoen Edwardsoen force-pushed the add_high_resolution_to_default_option branch from 284d6a6 to f411baa Compare May 14, 2023 12:44
@Edwardsoen
Copy link
Contributor Author

whops my bad, accidentally added a new line and removed "}" when trying to resolve conflict. Sorry could you re run the test. Thanks

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr force-pushed the add_high_resolution_to_default_option branch from f411baa to 95a97bb Compare September 17, 2023 23:43
@TobiGr TobiGr force-pushed the add_high_resolution_to_default_option branch from 95a97bb to 19640d5 Compare September 17, 2023 23:46
TobiGr
TobiGr approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the late review.
I rebased the PR, added some documentation and renamed a var. Code looks good!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr merged commit 1630e30 into TeamNewPipe:dev Sep 24, 2023
5 of 6 checks passed
This was referenced Oct 5, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to select default 2K/4K resolution
4 participants
@Edwardsoen @opusforlife2 @TobiGr @SameenAhnaf