-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash alias command substitution window resize bug #5417
Open
lap1nou
wants to merge
18
commits into
Textualize:main
Choose a base branch
from
lap1nou:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierog
reviewed
Dec 21, 2024
xavierog
reviewed
Dec 21, 2024
xavierog
reviewed
Dec 21, 2024
@lap1nou: Looks good to me. Questions for @willmcgugan and @darrenburns:
def _get_terminal_size(self) -> tuple[int, int]:
return (80, 25) if self._size is None else self._size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following checklist.
Docstrings on all new or modified functions / classesUpdated documentationGreetings,
I'm making this PR following a conversation with @xavierog (thanks to him) on Discord. I asked him for help regarding my TUI application.
My application was not resized correctly, the display was bugged and for example the Footer was disappearing, the thing is that I was running the Python application from a bash alias using command substitution (
alias cmd='$(python3 tui-app.py)'
), @xavierog discovered that the Textual driver was usingshutil.get_terminal_size()
to get the window size, but in that specific case, the function is failling because the command is ran from a bash command substitution.This PR aim to fix that specific (and probably uncommon) situation, I ran all tests and here is the results:
I had the same results with a fresh
Textual
clone so I don't think my changes broke any tests.