Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Describe checkpoint in GUI title #2624

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

openroad-robot
Copy link
Contributor

Before

Screenshot 2024-12-17 at 20 25 35

After

Screenshot 2024-12-17 at 20 22 16

Waiting on OR update with The-OpenROAD-Project/OpenROAD#6340

@povik
Copy link
Contributor

povik commented Dec 17, 2024

Screenshots (the ones above don't load for everyone)

Before
Screenshot 2024-12-17 at 20 25 35

After
Screenshot 2024-12-17 at 20 22 16

@maliberty
Copy link
Member

Stage is a bit vague as there can be multiple steps within one stage. It might be better to use the odb or def filename (without the path) being loaded as that is more specific.

@povik
Copy link
Contributor

povik commented Dec 17, 2024

Good point

Screenshot 2024-12-17 at 22 20 40

@maliberty maliberty enabled auto-merge December 17, 2024 21:35
@povik
Copy link
Contributor

povik commented Dec 17, 2024

@maliberty Sorry Matt I should have placed a more visible notice: This can't go in before we bump OR to get gui::set_title or we break the make gui targets (if this wasn't owned by the bot I would have marked it draft)

@maliberty maliberty disabled auto-merge December 17, 2024 21:43
@maliberty maliberty marked this pull request as draft December 17, 2024 21:43
@maliberty
Copy link
Member

I usually put "do not merge" in the title.

@povik
Copy link
Contributor

povik commented Dec 27, 2024

@maliberty can be merged now (OR bump in #2620)

@maliberty
Copy link
Member

Conflict to resolve

@maliberty maliberty marked this pull request as ready for review December 28, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants