Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sta: only add test subdirectory if tests enabled. #6455

Merged

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Jan 1, 2025

Fixes: #6453

Copy link
Contributor

github-actions bot commented Jan 1, 2025

clang-tidy review says "All clean, LGTM! 👍"

@hzeller hzeller force-pushed the feature-20250101-cond-test branch from 3efd312 to dd0314f Compare January 1, 2025 10:45
Copy link
Contributor

github-actions bot commented Jan 1, 2025

clang-tidy review says "All clean, LGTM! 👍"

@gadfort
Copy link
Collaborator

gadfort commented Jan 1, 2025

It's only the cpp tests that should be eliminated, so you can move this into the tests directory

@hzeller hzeller force-pushed the feature-20250101-cond-test branch from dd0314f to 77defcd Compare January 1, 2025 15:19
@hzeller
Copy link
Contributor Author

hzeller commented Jan 1, 2025

It's only the cpp tests that should be eliminated, so you can move this into the tests directory

Done.

Copy link
Contributor

github-actions bot commented Jan 1, 2025

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@gadfort gadfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eder-matheus eder-matheus enabled auto-merge January 1, 2025 16:18
@eder-matheus eder-matheus merged commit 06a891e into The-OpenROAD-Project:master Jan 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake configure fails for sta tests recently
3 participants