feat: Re-write of directory_writer in Julia #190
+89
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisO345
requested review from
Panquesito7,
uncomfyhalomacro and
Azzaare
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 142 142
Lines 1796 1796
=======================================
Hits 1753 1753
Misses 43 43 ☔ View full report in Codecov by Sentry. |
ChrisO345
changed the title
uncomfyhalomacro
previously approved these changes
Oct 4, 2023
Panquesito7
requested changes
Jan 15, 2024
| git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY | ||
| git add DIRECTORY.md | ||
| git commit -am "updating DIRECTORY.md" || true | ||
| git push --force origin HEAD:$GITHUB_REF || true |
There was a problem hiding this comment.
This won't work as the main branch is protected. We need to create a pull request, and then merge it, just like the previous workflow.
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote
directory_writer.jland changeddirectory_writer.ymlto use this file to build directory, rather than using a python script.