Add hints about HDD geometry issues, and spelling n*zi (spelling, typos, improvements) #40
+43
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better avoid syntax which causes vim to start doing strange things due to happening to match some automatic vim ex mode command features.
In newer Linux kernels, the values as returned by HDIO_GETGEO ioctl have been changed from BIOS-originating to what the kernel's HDIO_GETGEO ioctl callback functions think of the "geometry". This, from the POV of the ioctl being a *kernel-side* part and thus returning *kernel-side* information is correct handling - if only libata did actually return meaningful data rather than hard-coding LBA-type (255 heads) geometry values in its .getgeo() callback... This means that relying on kernel information may have become problematic for modifying data that is destined for non-kernel scope, which clearly is the case for NTFS tools such as this. Thus we better make sure to verbosely indicate where to possibly get geometry information that's possibly accurate for handling NTFS partitions for the BIOS-depending old-style-geometry Windows OSs. Side note: the upstream ntfsfixboot project provides a geo_override.c ld helper workaround to alter the result of HDIO_GETGEO ioctl if desired.
|
Sorry, this pull request is too old. Please update it again if necessary, or I will turn off this request in the future. Please forgive me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
since I had lots of "fun" with partclone.ntfsfixboot on an Extended CHS partition table vs. a narrow LBA-only (and thus *incompatible) view of newer Linux kernels, I decided to add details and warnings about this to usage message / docs, to try to prevent others (the documentation-reading kind of users ;) from hitting the same annoying geometry-challenged NTFS-side non-boot issues that I did.
Note that the usage message changes are potential ntfsfixboot project upstream material
(perhaps it's better to do larger backports from time to time though).
Also, correct many typos/spelling/others (this work might partially conflict with a recent pull request).
About the spelling n*zi thing: yes, I'm German, that ought to be authoritative enough ;-P
Please let me know in case something cannot be accepted as is (it's my first pull request anyway). Partial application certainly is ok (even complete redoing of questionable parts). All that matters is that it gets into the project, pronto :)
Thanks a ton for a very useful tool!