Fix the expectation of an extraneous checksum during restore/check in th... #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the last read When the last blocks are written and are less than cs_per_checksum, a last checksum is written for them. During restore/check, we compute how many bytes must be read (blocks+checksum). However, there is an error in the condition that add one more checksum to be read during the last read. That condition must takes into account the number of blocks already copied. Signed-off-by: Patrick Rouleau <[email protected]>
|
Sorry, this pull request is too old. Please update it again if necessary, or I will turn off this request in the future. Please forgive me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the expectation of an extraneous checksum during restore/check in the last read
When the last blocks are written and are less than cs_per_checksum, a last
checksum is written for them. During restore/check, we compute how many
bytes must be read (blocks+checksum).
However, there is an error in the condition that add one more checksum to
be read during the last read. That condition must takes into account the
number of blocks already copied.