fix AC_ARG_ENABLE so that --disable-* options work as expected #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if AC_ARG_ENABLE contains '--enable-foo' and user passes '--disable-foo' to './configure', '$enable_foo' will contain 'yes'. This commit strips 'action-if-(un)specified' arguments of AC_ARG_ENABLE in order to leverage the default behaviour, which sets `$enable_*' content appropriately.
Thomas-Tsai
added a commit
that referenced
this pull request
Oct 24, 2016
fix AC_ARG_ENABLE so that --disable-* options work as expected
Thomas-Tsai
added a commit
that referenced
this pull request
Feb 2, 2017
fix AC_ARG_ENABLE so that --disable-* options work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if AC_ARG_ENABLE contains '--enable-foo' and user passes
'--disable-foo' to './configure', '$enable_foo' will contain 'yes'.
This commit strips 'action-if-(un)specified' arguments of AC_ARG_ENABLE
in order to leverage the default behaviour, which sets `$enable_*'
content appropriately.
This PR is related to #59, but I hope that my solution is cleaner.