-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Newtonsoft.Json
package and migrate to System.Text.Json
#2124
Conversation
Merge 'ThreeMammals:develop' into 'develop'
Merge 'ThreeMammals:develop' into 'develop'
Newtonsoft.Json
package and migrate to System.Text.Json
Mohsen, thank you for the nice PR. However, I've noticed some instability in the CircleCI jobs on the feature branch, which seems to stem from issues in the develop branch. It's important to adhere to our development process by not creating feature branches from a broken develop branch.
Once these issues are resolved, we can commence the discussion on the feature. |
Thank you, Mohsen!
This is indeed correct! |
In this request, we deleted the newtonsoft package and migrated to text json system.
The reason for the changes
The changes given include the removal of Newtonsoft. A benchmark has also been added for this
@MohammadAminPourmoradian helped me with this
BenchmarkDotNet v0.13.11, Windows 11 (10.0.22631.3880/23H2/2023Update/SunValley3)
Intel Core i7-10870H CPU 2.20GHz, 1 CPU, 16 logical and 8 physical cores
.NET SDK 8.0.303
[Host] : .NET 6.0.32 (6.0.3224.31407), X64 RyuJIT AVX2 [AttachedDebugger]
.NET 8.0 : .NET 8.0.7 (8.0.724.31311), X64 RyuJIT AVX2
Job=.NET 8.0 Runtime=.NET 8.0