Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Tibia Char Bazaar endpoints #24

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tobiasehlert
Copy link
Member

This feature includes following endpoints:

  • current auctions
  • auction history
  • auction details

Original PR was #23

@tobiasehlert tobiasehlert added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code labels Jan 4, 2022
@JorgeMag96
Copy link
Contributor

Working on this. I will have the refactor changes according to SonarCloud Code Analysis soon.

Can we elaborate a bit more on the current auctions and auction history endpoints ?
Are these endpoints going to retrieve only the auctions that appear in the main page or should we add pagination ?

@tobiasehlert
Copy link
Member Author

Working on this. I will have the refactor changes according to SonarCloud Code Analysis soon.

Can we elaborate a bit more on the current auctions and auction history endpoints ? Are these endpoints going to retrieve only the auctions that appear in the main page or should we add pagination ?

Yeah, there where a couple of notes from SonarCloud so some things should be renamed/rewritten.
But yes, we definitely need pagination so that people can retrieve "all" current and historical auctions.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #24 (be534bc) into main (ce26e50) will decrease coverage by 8.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   58.38%   49.85%   -8.53%     
==========================================
  Files          21       22       +1     
  Lines        2595     3039     +444     
==========================================
  Hits         1515     1515              
- Misses       1023     1467     +444     
  Partials       57       57              

@TibiaData TibiaData deleted a comment from sonarqubecloud bot Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

2 participants