Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVEXP-1264] Upgrade PHP 7.1 #13

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[DEVEXP-1264] Upgrade PHP 7.1 #13

wants to merge 7 commits into from

Conversation

juanariastn
Copy link

@juanariastn juanariastn commented Jun 26, 2024 •
edited
Loading

DEVEXP-1264

Changes

  • Update to PHP 7.1
  • Update dependencies
  • Add rector tool to analyse and detect PHP version updates
  • Add README with helpful commands 👇

Helpful commands

Run lint

docker compose -f docker-compose.cli.yml run --rm php-cs-fixer fix --verbose

Run unit tests

docker compose run --no-deps --rm php-cli composer test

Run rector

docker compose run --no-deps --rm php-rector php ../rector/vendor/bin/rector process

@juanariastn
chore: ignore files and new line at EOF
7c9e425
@juanariastn
Update PHP version to 7.1
5b7aac2 
This update includes a shift from PHP 7.0 to PHP 7.1 in composer.json and docker-compose.cli.yml and a significant change in the Dockerfile setup.
Additionally, composer.json and GitHub action files have been modified to comply with the new updates.
@juanariastn
Add Rector and associated Docker setup
8b1a4e2 
This commit introduces `rector.php` to implement a type declaration rector rule, and adds a Dockerfile for `php-rector`. Additionally, a `php-rector` service is integrated into the `docker-compose.yml` file to ensure the proper Docker container setup.
@juanariastn
Fix lint
7749edf 
Add return type declarations to test methods

Minor adjustments were made to the class constants declaration in WebpOptimizer, making the constants public explicitly.
@juanariastn juanariastn self-assigned this Jun 26, 2024
@juanariastn
Fix PHP extensions in Dockerfile
afed938 
The PHP extensions in the Dockerfile have been rearranged and php${PHP_VERSION}-mbstring has been added.
@juanariastn juanariastn changed the title [DEVEXP-1264] Update PHP 7.1 [DEVEXP-1264] Upgrade PHP 7.1 Jun 26, 2024
cacciaresi
cacciaresi requested changes Jun 26, 2024
View reviewed changes
.docker/php-cli/Dockerfile Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@juanariastn
Remove sendmail_path from PHP ini
b601346 
The sendmail_path directive has been removed from PHP configuration overrides. The file php-ini-overrides-phpdbg.ini was deleted from the PHP CLI Docker setup, and the related COPY instruction has been removed from the Dockerfile.
@juanariastn
Add README.md
e22ce50 
A README.md file has been created, providing library information and instructions for running lint, unit tests, and rector. In addition, unnecessary scripts in composer.json have been removed.
@juanariastn juanariastn requested a review from cacciaresi June 26, 2024 18:38
@cacciaresi cacciaresi marked this pull request as draft June 26, 2024 20:34
@juanariastn juanariastn marked this pull request as ready for review November 1, 2024 17:12
@cacciaresi cacciaresi removed their request for review November 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacciaresi cacciaresi cacciaresi requested changes

@tchimenti tchimenti Awaiting requested review from tchimenti

Requested changes must be addressed to merge this pull request.

Assignees

@juanariastn juanariastn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanariastn @cacciaresi