Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python cmake issue #702

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Fix python cmake issue #702

merged 2 commits into from
Apr 17, 2024

Conversation

gspowley
Copy link
Member

@gspowley gspowley commented Apr 17, 2024

Fix an issue introduced in #701 by providing a list of shared libs to install explicitly.

@gspowley gspowley requested review from jdblischak and awenocur April 17, 2024 02:36
jdblischak added a commit to jdblischak/tiledb-vcf-feedstock that referenced this pull request Apr 17, 2024
@jdblischak
Copy link
Collaborator

Testing now in jdblischak/tiledb-vcf-feedstock@06b1842

@gspowley
Copy link
Member Author

Thanks @jdblischak. Based on your test, I see we need to be explicit about the shared libraries installed. The latest commit should install only the required libraries.

@jdblischak
Copy link
Collaborator

@gspowley Thanks! I manually triggered another CI run to test your latest changes

https://dev.azure.com/jdblischak/feedstock-builds/_build/results?buildId=748&view=results

Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedstock build passed

@gspowley gspowley merged commit 964be5c into main Apr 17, 2024
13 checks passed
@gspowley gspowley deleted the gspowley/fix-python-cmake branch April 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants