Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.32, which uses scikit-build-core #120

Merged
merged 5 commits into from
May 10, 2024

Conversation

jdblischak
Copy link
Collaborator

This PR updates the conda recipe to use the new scikit-build-core setup introduced in TileDB-Inc/TileDB-VCF#701

The previous workaround to enable setuptools-scm to work with a GitHub release tarball (TileDB-Inc/TileDB-VCF#85) no longer works with scikit-build-core. Thus we are switching to using Git tags as the recipe source.

Once we have released/tagged 0.32.0, we just have to update the version string in recipe/meta.yaml

@jdblischak jdblischak requested review from awenocur and gspowley May 9, 2024 18:54
@jdblischak
Copy link
Collaborator Author

Note that as I reported in TileDB-Inc/TileDB-VCF#717, the new scikit-build-core setup is copying all the shared objects into the Python installation. Thus the tiledbvcf-py conda binary will now be bundling libtiledb.so, libtiledbvcf.so, and htslib.so.

# linux-64
  [100%] Built target libtiledbvcf
  *** Installing project into wheel...
  -- Install configuration: "Release"
  -- Installing: /tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libtiledbvcf.cpython-310-x86_64-linux-gnu.so
  -- Set non-toolchain portion of runtime path of "/tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libtiledbvcf.cpython-310-x86_64-linux-gnu.so" to "$ORIGIN"
  -- Installing: /tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libtiledb.so
  -- Installing: /tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libtiledb.so.2.22
  -- Installing: /tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libtiledbvcf.so
  -- Installing: /tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libhts.so
  -- Installing: /tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libhts.so.1.19
  -- Installing: /tmp/tmpgwstszjd/wheel/platlib/tiledbvcf/libhts.so.3
  -- Installing: /tmp/tmpgwstszjd/wheel/scripts/tiledbvcf
  *** Making wheel...
  *** Created tiledbvcf-0.32.0rc1-cp310-cp310-linux_x86_64.whl...
  Building wheel for tiledbvcf (pyproject.toml): finished with status 'done'
  Created wheel for tiledbvcf: filename=tiledbvcf-0.32.0rc1-cp310-cp310-linux_x86_64.whl size=15113109 sha256=8b287244e9aad9f5a0749dec4d1d0f5a4c06897d82b4a48520d45f5227e96cbc
  Stored in directory: /tmp/pip-ephem-wheel-cache-41w9yw9f/wheels/7a/71/3f/5e595831020bad05f6a2f1ca3a1b0057d5a2a05c13488be84d
Successfully built tiledbvcf
Installing collected packages: tiledbvcf
Successfully installed tiledbvcf-0.32.0rc1

# osx-64
  [100%] Built target libtiledbvcf
  *** Installing project into wheel...
  -- Install configuration: "Release"
  -- Installing: /tmp/tmpijkidqc_/wheel/platlib/tiledbvcf/libtiledbvcf.cpython-310-darwin.so
  -- Installing: /tmp/tmpijkidqc_/wheel/platlib/tiledbvcf/libtiledb.dylib
  -- Installing: /tmp/tmpijkidqc_/wheel/platlib/tiledbvcf/libtiledbvcf.dylib
  -- Installing: /tmp/tmpijkidqc_/wheel/platlib/tiledbvcf/libhts.1.19.dylib
  -- Installing: /tmp/tmpijkidqc_/wheel/platlib/tiledbvcf/libhts.3.dylib
  -- Installing: /tmp/tmpijkidqc_/wheel/platlib/tiledbvcf/libhts.dylib
  -- Installing: /tmp/tmpijkidqc_/wheel/scripts/tiledbvcf
  *** Making wheel...
  *** Created tiledbvcf-0.32.0rc1-cp310-cp310-macosx_10_15_x86_64.whl...
  Building wheel for tiledbvcf (pyproject.toml): finished with status 'done'
  Created wheel for tiledbvcf: filename=tiledbvcf-0.32.0rc1-cp310-cp310-macosx_10_15_x86_64.whl size=8858398 sha256=277e54f22df4644d9d9d9edc55efe20ab02188e0663ab4153ca1572ad207ea55
  Stored in directory: /private/tmp/pip-ephem-wheel-cache-5u13rsid/wheels/77/02/78/1d0b76ffb75e2047c887352819830471fce2a365feec794e70
Successfully built tiledbvcf
Installing collected packages: tiledbvcf
Successfully installed tiledbvcf-0.32.0rc1

@jdblischak jdblischak marked this pull request as ready for review May 10, 2024 14:10
@awenocur awenocur merged commit 512f6a9 into TileDB-Inc:master May 10, 2024
3 of 5 checks passed
@jdblischak jdblischak deleted the 0.32 branch May 10, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants