Install new VSI plugin handler for every instance of using an opener #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin handler installation is implicit and hidden from the API user, but could be exposed in the future if needed. Resolves #1406
This involves adding GDAL callback support for unlinking VSI files and also a major stat() bug fix.
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1406 by giving each
fiona.open()collection its own VSI plugin handler when theopenerkeyword argument is used. Works with threads.The approach is not unlike the one mentioned in OSGeo/gdal#8772 and benefits from the
VSIRemovePluginHandler()function added in GDAL 3.9.0. With older versions of GDAL, the Pyopener registry will accumulate openers and GDAL will accumulate plugin handlers.This PR also adds and uses Rasterio's chaining error handler and error stack checker.