Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test CI: Update Conda jobs to Python 3.12 #1422

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Aug 3, 2024

Python 3.12 is faster, gives better error messages, includes more up-to-date deprecation warnings, and is now properly supported (for some time) on Conda.

EwoutH added 2 commits August 3, 2024 21:56
Python 3.12 is faster, gives better error messages, includes more up-to-date deprecation warnings, and is now properly supported (for some time) on Conda.
Use the python-version defined in the build matrix to set up the conda environment.
@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 3, 2024

It seems we have to wait a little until conda-forge/miniforge#603 is included in a new miniforge release.

@hmaarrfk
Copy link

hmaarrfk commented Aug 3, 2024

The error is not due to what you linked to. In your Cis you are creating new environments isolated from the base one

Your Linux 3.12 jobs are passing.

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 4, 2024

Could you rerun the failed ones?

We're not using codecov anymore.
@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 12, 2024

CI is fully green!

Copy link
Member

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EwoutH !

@sgillies sgillies merged commit 54445e2 into Toblerity:main Aug 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants