feat: Implement pre-initialized Docker container pool to improve /eval #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l request performance - Added a pool of pre-initialized Docker containers, each assigned a unique session ID and ready for immediate use. - Pre-configured each container with the necessary startup scripts to ensure environments are ready for /eval requests. - On receiving a new /eval request, the system now allocates a container from the pool, reducing the need to create and initialize a container on demand. - Improved request latency by significantly reducing the time taken to start and initialize Docker containers during each session.
- Ran code formatting and styling checks using Spotless to ensure consistent code style. - Performed code analysis and linting with SonarQube to identify and address potential issues. - Fixed minor issues flagged during the linting process to enhance code quality.
EmmanuelStan12
force-pushed
the
feature/docker-container-pool-for-eval
branch
from
8adf7b0 to
94ffa88
Compare
- Added functionality to persist input and output streams of newly created or cached Docker containers using a ConcurrentHashMap. - Ensured that container streams are properly managed and retrievable for future requests, improving container reuse. - Fixed test case issues related to stream management and container lifecycle, ensuring tests pass consistently.
Alathreon
requested changes
Oct 20, 2024
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Outdated
Show resolved
Hide resolved
JShellAPI/src/main/java/org/togetherjava/jshellapi/service/DockerService.java
Show resolved
Hide resolved
EmmanuelStan12
force-pushed
the
feature/docker-container-pool-for-eval
branch
from
fd7b998 to
168a26c
Compare
EmmanuelStan12
force-pushed
the
feature/docker-container-pool-for-eval
branch
from
168a26c to
e40b62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant performance improvements for the /eval request process by implementing a pool of pre-initialized Docker containers. Previously, each request required a new container to be created and initialized, which added latency to the response time. These changes optimize that process, ensuring faster response times and better resource management.
Key changes include: