Add comments

Tom-Newton · Jan 18, 2024 · 6d59872 · 6d59872
1 parent 68aef2f
commit 6d59872
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/scala/build.sbt b/scala/build.sbt
@@ -12,8 +12,13 @@ lazy val root = (project in file("."))
   )
 
 libraryDependencies ++= Seq(
+  // Databricks 10.4 uses spark 3.2.1 but apparently its closer to 3.3.0
+  // open source spark. 
   "org.apache.spark" %% "spark-core" % "3.3.0" % "provided",
   "org.apache.spark" %% "spark-sql" % "3.3.0" % "provided",
   "org.scalactic" %% "scalactic" % "3.2.12",
   "org.scalatest" %% "scalatest" % "3.2.12" % "test"
 )
+
+// For Databricks 10.4 we need to compile against old java. Java 11 works
+// `sbt -java-home /usr/lib/jvm/java-11-openjdk-amd64/ package`
diff --git a/scala/src/main/scala/logical/PITJoin.scala b/scala/src/main/scala/logical/PITJoin.scala
@@ -34,6 +34,8 @@ import org.apache.spark.sql.catalyst.expressions.{
 import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
 import org.apache.spark.sql.types.BooleanType
 import org.apache.spark.sql.catalyst.trees.BinaryLike
+
+// Databricks 10.4 doesn't define this trait so define it here. 
 trait BinaryNode extends LogicalPlan with BinaryLike[LogicalPlan]
 protected[pit] sealed abstract class CustomJoinType {
   def sql: String