Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Status Code in HTTP Response for WebSocket Handshake #1424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjm159
Copy link

@jjm159 jjm159 commented Jun 19, 2024

Description

I modified generateHttpResponseDueToError to accept errorCode and errorMessage, allowing the library user to determine the message included in the HTTP response status line.

Related Issue

#1423

How Has This Been Tested?

I implemented onWebsocketHandshakeReceivedAsServer and induced an error during the socket connection. I confirmed that the desired status code and message were added to the response status line.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant