Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update requirements and documentation for benchmark_runner #29

Closed
wants to merge 3 commits into from

Conversation

andrewsu
Copy link
Collaborator

on a fresh installation/environment, reasoner_pydantic needs to be installed

$ benchmarks_fetch
Traceback (most recent call last):
  File "/home/asu/env/benchmarks-pypi/bin/benchmarks_fetch", line 5, in <module>
    from benchmarks.cli.fetch import main
  File "/home/asu/Science/Benchmarks-pypi/benchmarks/cli/fetch.py", line 3, in <module>
    from benchmarks.request import fetch_results
  File "/home/asu/Science/Benchmarks-pypi/benchmarks/request.py", line 12, in <module>
    from reasoner_pydantic import Response
ModuleNotFoundError: No module named 'reasoner_pydantic'
(benchmarks-pypi) asu@LAPTOP-FKGA5D64:Benchmarks-pypi$ pip install reasoner_pydantic
Collecting reasoner_pydantic
  Downloading reasoner_pydantic-4.1.5-py3-none-any.whl.metadata (3.1 kB)
Collecting pydantic<2,>=1.8 (from reasoner_pydantic)
  Downloading pydantic-1.10.13-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (149 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 149.6/149.6 kB 4.8 MB/s eta 0:00:00
Requirement already satisfied: typing-extensions>=4.2.0 in /home/asu/env/benchmarks-pypi/lib/python3.10/site-packages (from pydantic<2,>=1.8->reasoner_pydantic) (4.8.0)
Downloading reasoner_pydantic-4.1.5-py3-none-any.whl (15 kB)
Downloading pydantic-1.10.13-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.1 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 14.2 MB/s eta 0:00:00
Installing collected packages: pydantic, reasoner_pydantic
  Attempting uninstall: pydantic
    Found existing installation: pydantic 2.4.2
    Uninstalling pydantic-2.4.2:
      Successfully uninstalled pydantic-2.4.2
Successfully installed pydantic-1.10.13 reasoner_pydantic-4.1.5
(benchmarks-pypi) asu@LAPTOP-FKGA5D64:Benchmarks-pypi$ benchmarks_fetch
usage: benchmarks_fetch [-h] [--overwrite] [--unscored] [--n N] benchmark target results_dir
benchmarks_fetch: error: the following arguments are required: benchmark, target, results_dir

@andrewsu andrewsu changed the title add reasoner_pydantic update requirements and documentation for benchmark_runner Nov 10, 2023
@andrewsu
Copy link
Collaborator Author

also added some fixes to the README based on what was needed on my system...

Also, @maximusunc, I noticed with the new branch, I can't run benchmarks_fetch from the command line. Did I miss something?

$ benchmarks_fetch
Traceback (most recent call last):
  File "/home/asu/env/benchmarks-pypi/bin/benchmarks_fetch", line 33, in <module>
    sys.exit(load_entry_point('benchmarks-runner', 'console_scripts', 'benchmarks_fetch')())
  File "/home/asu/env/benchmarks-pypi/bin/benchmarks_fetch", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'benchmarks'

@maximusunc
Copy link
Collaborator

maximusunc commented Nov 13, 2023

Fixed the benchmarks_fetch issue and added these changes to #28 .

@maximusunc maximusunc closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants