Anonymize TIM-Manager Solution #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccoystephenson
requested changes
Dec 13, 2024
cv-data-service-library/src/main/java/com/trihydro/library/helpers/DbInteractions.java
Show resolved
Hide resolved
cv-data-service-library/src/main/java/com/trihydro/library/helpers/JsonToJavaConverter.java
Outdated
Show resolved
Hide resolved
cv-data-service-library/src/test/resources/application.properties
Outdated
Show resolved
Hide resolved
mcook42
approved these changes
Dec 13, 2024
|
|
||
| protected DbInteractionsProps dbConfig; | ||
| protected Utility utility; | ||
| protected EmailHelper emailHelper; | ||
| private EmailHelper emailHelper; | ||
|
|
||
| @Autowired | ||
| public void InjectDependencies(DbInteractionsProps props, Utility _utility, EmailHelper _emailHelper) { |
There was a problem hiding this comment.
note(non-blocking): the standard way to let Spring manage the component bean and its dependencies is to define a constructor. For example, instead of
@Autowired
public void InjectDependencies(DbInteractionsProps props, Utility _utility, EmailHelper _emailHelper) {we would do something like
public DbInteractions(DbInteractionsProps props, Utility utility, EmailHelper emailHelper) {This removes the need for the @Autowired annotation and makes it clear which parameters this class needs when instantiated.
This is a note only. I would not suggest changing the constructor in this PR.
dmccoystephenson
approved these changes
Dec 16, 2024
payneBrandon
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the anonymization changes that were approved in the WyoCV repo in addition to the changes present in #1. This PR also includes the BOWR TIM type addition from #3 .