-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shop products page is added - issue #266 #331
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Is it necessary to use hardcoded image in base64 format? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Width is too large according to me which hinders the overall image height. @clownfish1805
What you say @Suman373 ?
Yes and the image format reduces the code readability |
@Suman373 @Trisha-tech |
Yes. But some images have base64 string in the image source. Could u please make them an image url from unsplash too? |
@clownfish1805 pls resolve the conflicts |
Description
Related Issues
Changes
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.
npm install
to install dependencies.npm test
to execute the test suite.Screenshots (if applicable)