Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop products page is added - issue #266 #331

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

clownfish1805
Copy link

Description

  • A responsive layout that displays a list of available products with images, descriptions, and prices.
  • Functional Search buttons, ensuring a smooth user experience.
  • A navigation menu for easy access to other sections of the website, including the home page and cart.
  • Adherence to the website's design guidelines for consistency in styling and user interface.

Related Issues

Changes

  • Fixed a bug in Shop page is not available / gives 404 error

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that the shop page is visible

Screenshots (if applicable)

image

Copy link

github-actions bot commented Oct 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Suman373
Copy link
Collaborator

Suman373 commented Oct 6, 2024

Is it necessary to use hardcoded image in base64 format?

Copy link
Owner

@Trisha-tech Trisha-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Width is too large according to me which hinders the overall image height. @clownfish1805
What you say @Suman373 ?

@Suman373
Copy link
Collaborator

Suman373 commented Oct 7, 2024

Width is too large according to me which hinders the overall image height. @clownfish1805 What you say @Suman373 ?

Yes and the image format reduces the code readability

@clownfish1805
Copy link
Author

@Suman373 @Trisha-tech
I have reduced the width and improved the height
image

@Suman373
Copy link
Collaborator

Suman373 commented Oct 7, 2024

@Suman373 @Trisha-tech I have reduced the width and improved the height image

Yes. But some images have base64 string in the image source. Could u please make them an image url from unsplash too?

@Suman373
Copy link
Collaborator

Suman373 commented Oct 7, 2024

Screenshot_2024-10-08-00-09-39-589_com android chrome

U can see how long this source for the image is. It will affect code readability as it is a standard to be maintained.

@mridulsaggi
Copy link
Collaborator

@clownfish1805 pls resolve the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Shop page is not available / gives 404 error
4 participants