[ISSUE-47] support run on ray community version #89
Conversation
|
|
cbqiao
force-pushed
the
support_ray_community
branch
from
c9ab3ff to
66b9c14
Compare
There was a problem hiding this comment.
Can we add a document for geaflow on ray tutorial? For example, we should explain how to install ray. Here is the doc about ray installation https://docs.ray.io/en/latest/ray-overview/installation.html
| @@ -41,6 +42,7 @@ public static ActorHandle<RayMasterRunner> createMaster(ClusterConfig clusterCon | |||
| ActorHandle<RayMasterRunner> masterRayActor = Ray | |||
| .actor(RayMasterRunner::new, clusterConfig.getConfig()) | |||
| .setMaxRestarts(clusterConfig.getMaxRestarts()) | |||
| .setLifetime(ActorLifetime.DETACHED) | |||
There was a problem hiding this comment.
"detached" actor will not be killed when the ray job is finished or failed. Does it make sense for your scenes? For more detail, you can read this doc https://docs.ray.io/en/latest/ray-core/actors/named-actors.html?highlight=detached#actor-lifetimes
There was a problem hiding this comment.
it make sense for out scenes. we expected the actor run with long-running mode.
| */ | ||
| RAY, | ||
| RAY_COMMUNITY, |
There was a problem hiding this comment.
I'm concerning about this. Why we rename ray to ray community? For the open source software, the meaning of "ray" is "open source ray" by default. I think we don't need to rename it because there is only one ray project in community currently. "RAY_COMMUNITY" is confusing for open source users.
cbqiao
force-pushed
the
support_ray_community
branch
from
66b9c14 to
5903f25
Compare
What changes were proposed in this pull request?
How was this PR tested?