Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wx3.0's document:
wx3.1+:
Now the biggest problem is that there's no wx3.1 or wx3.2 in the official repo of Debian 11 or Ubuntu 20.04/22.04, only wx3.0. Should we turn to depend on wx3.2 from third-party (CodeLite), or we just build
wxwidgets
subprojects from source during Ubuntu build? An interim alternative is that#if wxCHECK_VERSION(3,1,0)
use the native one#else
fallback toPlaceholder<>
. we keep the originalPlaceholder<>
until late-2024 or 2025. If you think the alternative is better I'll push it to here.BTW I don't know whether
SetHint
have native wxQt support. Arch Linux have thewxwidgets-qt5
package but i guess there's almost no wxqt users on Arch, because I had tried to build Aegisub with it and found this wxqt package was broken for a long period 😹. Therefore, few people will be affected by this PR even if no native wxQt support.