Arm Firmware Master PR #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll require further adjustments to recieve commands from moveit node
… out rosserial APIs to send strings to teensy
…sition sending while in joint mode
* Add ROS driver for Piksi gps module Add supporting Swift Navigation Binary Library to external libs folder (libsbp) * Cleaned Up PR mistakes * More minor mistakes * Fixed name of external piksi * Told ROS to not look for libswiftnav * Fixed spelling error * fixed line 54 to make install_dependencies.sh skip libswiftnav. * fixed error in install_libspb, corrected a change directory
* Initialize marker and qr detection nodes * Add cv_bridge and opencv dependencies to marker_qr_detection package * Draft implementation of marker detection node * Add ROS to OpenCV helper functions and datatypes * Remove default parameter from functions and sketch QR code detection * Added launch file that sets draw_markers parameter to true * fixed spelling errors. Code is able to scan markers and relay the marker id * Now DetectMarker draws and publishes the bounding box + id to the bounding_boxes topic * just saving * just saving, work in progress * saving * hello * Added camera parameter to choose between realsense cameras. Also cleaned up and removed code * cleaned up comments * set up image saver class and header * compiled * added functionality of saving photos from eiter camera * made sure CIRC_Images is included * wee waa * remove data.cpp * Formatted source files Co-authored-by: Ihsan Olawale <[email protected]>
…ll require further adjustments to recieve commands from moveit node
…nowbots#421) * Swap X & Y axes on left joystick in wheel mode * Move setup call and use ROS_DEBUG when debug is set to true * Change speed of rover via arrowbuttons * Format ProController.cpp Co-authored-by: TateKolton <[email protected]>
* Add ROS driver for Piksi gps module Add supporting Swift Navigation Binary Library to external libs folder (libsbp) * Cleaned Up PR mistakes * More minor mistakes * Fixed name of external piksi * Told ROS to not look for libswiftnav * Fixed spelling error * fixed line 54 to make install_dependencies.sh skip libswiftnav. * fixed error in install_libspb, corrected a change directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Give a high-level description of the changes in this PR
Testing Done
Outline any testing that was done for these changes. This could be unit tests, integration tests, etc.
Resolved Issues
Link any issues that this PR resolved. Eg
resolves #1, #2, and #5(note that they MUST be specified like this so Github can automatically close them then this PR merges)Review Checklist
(Please check every item to indicate your code complies with it (by changing
[ ]->[x]). This will hopefully save both you and the reviewer(s) a lot of time!)It is the reviewers responsibility to also make sure every item here has been covered
.cppand.hfile should have a comment at the start of it. See files insrc/sample_packagefor examples..hfile) should have a javadoc style comment at the start of them. For examples, see the classes defined insrc/sample_packageTODO(or similar) statements should either be completed or associated with a github issueFeel free to make additions of things that we should be checking to this file if you think there's something missing!!!!