Dc sb alert #185
Open
Dc sb alert #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for the alert text box |
|
Use the |
spelkey-ucd
requested changes
Jul 28, 2022
| @@ -20,7 +20,8 @@ function __construct($editor_script_slug, $settings=array()) { | |||
|
|
|||
| $this->iconsUsed = [ | |||
| 'ucd-public:fa-star', | |||
| 'ucd-public:fa-circle-chevron-right' | |||
| 'ucd-public:fa-circle-chevron-right', | |||
There was a problem hiding this comment.
Adding it this way, will load the icon on every single page even if the block isn't used.
Instead, create a block transformation where you set the icon attribute to ucd-public:fa-circle-exclamation
| const { attributes, setAttributes } = props; | ||
| const blockProps = useBlockProps(); | ||
|
|
||
| const mainEleProps = () => { |
| @@ -0,0 +1,8 @@ | |||
| import { html } from "../../utils"; | |||
There was a problem hiding this comment.
instead of innerblocks, use richtext component and save text as an attribute
| @@ -276,6 +276,9 @@ const template = html` | |||
| <g id="fa-fill" viewBox="0 0 512 512"> | |||
| <path d="M502.63 217.06L294.94 9.37C288.69 3.12 280.5 0 272.31 0s-16.38 3.12-22.62 9.37l-81.58 81.58L81.93 4.77c-6.24-6.25-16.38-6.25-22.62 0L36.69 27.38c-6.24 6.25-6.24 16.38 0 22.63l86.19 86.18-94.76 94.76c-37.49 37.49-37.49 98.26 0 135.75l117.19 117.19c18.75 18.74 43.31 28.12 67.87 28.12 24.57 0 49.13-9.37 67.88-28.12l221.57-221.57c12.49-12.5 12.49-32.76 0-45.26zm-116.22 70.97H65.93c1.36-3.84 3.57-7.98 7.43-11.83l13.15-13.15 81.61-81.61 58.61 58.6c12.49 12.49 32.75 12.49 45.24 0 12.49-12.49 12.49-32.75 0-45.24l-58.61-58.6 58.95-58.95 162.45 162.44-48.35 48.34z"/> | |||
| </g> | |||
| <g id="fa-circle-exclamation" viewBox="0 0 512 512"> | |||
There was a problem hiding this comment.
- this is a dynamically generated file. your change will be overwritten the next time the icon set is regenerated.
- This icon should already be loaded in the editor side, so no need to add it.
| @@ -350,6 +350,27 @@ hr.dotted { | |||
| border-top: 4px dotted; | |||
| } | |||
|
|
|||
| .alertIcon { | |||
| color:red; | |||
| .alertdiv { | ||
| background-color: #FFFFFF; | ||
| padding:5px; | ||
| color: red; |
|
|
||
| } | ||
| .divAlertContent { | ||
| display:inline-block; |
There was a problem hiding this comment.
use flex! soooo much easier to align....
| font-weight: bold; | ||
| } | ||
| .alertdiv { | ||
| background-color: #FFFFFF; |
There was a problem hiding this comment.
inherit the background color. kimmy frequently uses lightly shaded sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.